hackrf_transfer: align rate limits with MIN/MAX_MCU_RATE#1791
Open
mildsunrise wants to merge 1 commit into
Open
hackrf_transfer: align rate limits with MIN/MAX_MCU_RATE#1791mildsunrise wants to merge 1 commit into
mildsunrise wants to merge 1 commit into
Conversation
now that we have hardware-enforced sample rate limits, I think it'd be nice to align the checks done in hackrf_transfer with those. if worried about expanding these limits breaking older firmware, I can add an USB API check for >= 1.11. related to greatscottgadgets#1787 but seems to have no conflicts, feel free to close if you want to add that patch there :)
Member
|
Good point. We might want to make the expansion to 21.8MHz require the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
now that we have hardware-enforced sample rate limits, I think it'd be nice to align the checks done in hackrf_transfer with those. if worried about expanding these limits breaking older firmware, I can add an USB API check for >= 1.11.
related to #1787 but seems to have no conflicts, feel free to close if you want to add that patch there :)