GCI2 and GCI35 raising unattended exceptions

[FredericSouchon]

Hello,

In our large CI facility we had to deactivate these rules because they raise exceptions that are both related ti tree analysis

ex pour GCI2 :

16:10:00  [2025-11-17T15:10:00.311Z] 16:10:00.122 WARN  Could not analyse src/Average.php
16:10:00  [2025-11-17T15:10:00.311Z] java.lang.NullPointerException: Cannot invoke "java.util.Map.entrySet()" because the return value of "fr.greencodeinitiative.php.checks.AvoidMultipleIfElseStatementCheck$VariablesPerLevelDataStructure.getVariablesForCurrentIfStruct(int)" is null
16:10:00  [2025-11-17T15:10:00.311Z] 	at fr.greencodeinitiative.php.checks.AvoidMultipleIfElseStatementCheck.computeElseVariables(AvoidMultipleIfElseStatementCheck.java:260)
16:10:00  [2025-11-17T15:10:00.311Z] 	at fr.greencodeinitiative.php.checks.AvoidMultipleIfElseStatementCheck.visitElseNode(AvoidMultipleIfElseStatementCheck.java:247)
16:10:00  [2025-11-17T15:10:00.311Z] 	at fr.greencodeinitiative.php.checks.AvoidMultipleIfElseStatementCheck.visitIfNode(AvoidMultipleIfElseStatementCheck.java:126)
16:10:00  [2025-11-17T15:10:00.311Z] 	at fr.greencodeinitiative.php.checks.AvoidMultipleIfElseStatementCheck.visitNodeContent(AvoidMultipleIfElseStatementCheck.java:93)
16:10:00  [2025-11-17T15:10:00.312Z] 	at fr.greencodeinitiative.php.checks.AvoidMultipleIfElseStatementCheck.visitNode(AvoidMultipleIfElseStatementCheck.java:73)
16:10:00  [2025-11-17T15:10:00.312Z] 	at org.sonar.plugins.php.api.visitors.PHPTreeSubscriber.visit(PHPTreeSubscriber.java:48)

[...]

ex for GCI35 :

16:10:00  [2025-11-17T15:10:00.311Z] 16:10:00.122 WARN  Could not analyse src/Average.php
16:10:00  [2025-11-17T15:10:00.311Z] java.lang.NullPointerException: Cannot invoke "java.util.Map.entrySet()" because the return value of "fr.greencodeinitiative.php.checks.AvoidMultipleIfElseStatementCheck$VariablesPerLevelDataStructure.getVariablesForCurrentIfStruct(int)" is null
16:10:00  [2025-11-17T15:10:00.311Z] 	at fr.greencodeinitiative.php.checks.AvoidMultipleIfElseStatementCheck.computeElseVariables(AvoidMultipleIfElseStatementCheck.java:260)
16:10:00  [2025-11-17T15:10:00.311Z] 	at fr.greencodeinitiative.php.checks.AvoidMultipleIfElseStatementCheck.visitElseNode(AvoidMultipleIfElseStatementCheck.java:247)
16:10:00  [2025-11-17T15:10:00.311Z] 	at fr.greencodeinitiative.php.checks.AvoidMultipleIfElseStatementCheck.visitIfNode(AvoidMultipleIfElseStatementCheck.java:126)
16:10:00  [2025-11-17T15:10:00.311Z] 	at fr.greencodeinitiative.php.checks.AvoidMultipleIfElseStatementCheck.visitNodeContent(AvoidMultipleIfElseStatementCheck.java:93)
16:10:00  [2025-11-17T15:10:00.312Z] 	at fr.greencodeinitiative.php.checks.AvoidMultipleIfElseStatementCheck.visitNode(AvoidMultipleIfElseStatementCheck.java:73)
16:10:00  [2025-11-17T15:10:00.312Z] 	at org.sonar.plugins.php.api.visitors.PHPTreeSubscriber.visit(PHPTreeSubscriber.java:48)

[...]

[dedece35]

Hi @FredericSouchon ,
thank you for the issue.
Could you give us some piece of code to reproduce the problem ?

[FredericSouchon]

of course here is the content of the only one file oh the project :

<?php

	namespace drmonkeyninja;

	class Average
	{
		/**
		 * Calculate the mean average
		 * @param array $numbers Array of numbers
		 * @return float Mean average
		 */
		public function mean(array $numbers)
		{
            // Mauvaise pratique ecocode-php:EC22 insérée intentionnellement
            // Permet de vérifier le bon fonctionnement du plugin SonarQube ecocode-php
            // NE PAS SUPPRIMER LA LIGNE CI-DESSOUS
			return array_sum($numbers) / count($numbers);
		}

		/**
		 * Calculate the median average
		 * @param array $numbers Array of numbers
		 * @return float Median average
		 */
		public function median(array $numbers)
		{
			sort($numbers);
			$size = count($numbers);
			if ($size % 2) {
				return $numbers[(int)($size / 2)];
			} else {
				return $this->mean(
					array_slice($numbers, ($size / 2) - 1, 2)
				);
			}
		}
	}
?>

[dedece35]

Hi @FredericSouchon,
sorry for the delay of my answer.

Your example is ok to reproduce the NPE for GCI2 but not for GCI35.
The example given for GCI35 show an NPE on AvoidMultipleIfElseStatementCheck class wichi is the implementation for GCI2 and not for GCI35 (implementation class is "GCI35AvoidTryCatchWithFileOpenedCheck")

Could you give me an example for GCI35 please ?

I added also a Test resources file for GCI2 and GCI35 and all is ok for me but I'd like to check with your example for GCI35.