Skip to content

Adds more databases and benchmarks#20

Closed
ribalba wants to merge 12 commits into
mainfrom
new-dbs-and-tpch
Closed

Adds more databases and benchmarks#20
ribalba wants to merge 12 commits into
mainfrom
new-dbs-and-tpch

Conversation

@ribalba

@ribalba ribalba commented Jul 1, 2026

Copy link
Copy Markdown
Member

All the runs work on the cluster

@ribalba
ribalba requested a review from ArneTR July 1, 2026 11:28
@ArneTR

ArneTR commented Jul 2, 2026

Copy link
Copy Markdown
Member

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Jul 2, 2026

Copy link
Copy Markdown
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@ArneTR

ArneTR commented Jul 2, 2026

Copy link
Copy Markdown
Member

@coderabbitai re-review

@coderabbitai

coderabbitai Bot commented Jul 2, 2026

Copy link
Copy Markdown

@ArneTR: Sure, I'll re-review the changes now.

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@ArneTR

ArneTR commented Jul 7, 2026

Copy link
Copy Markdown
Member

This PR is so big that I have quite some trouble reviewing it sadly :/

I also tried with coderabbit but even that failed as it, according to the support, has a 150 file limit.

Is there a way to split this PR up so that at least we can have it reviewed by AI?

One note I could find in my review attempt:

  • I have read the benchmark design and tuning readme and find the approach plausible and accurate. But it is still very opaque to me on what grounds T1 and T2 optimizations happen. I do not feel I can reason about it or reproduce it. To give an example: It feels like for the DBs they are setting very different values - For instance benchmarks/chbenchmark/mysql.t1.yml and benchmarks/chbenchmark/oracle.t1.yml seem to set totally different settings. Is that a weird example I picked out or are the DB settings not that well comparable after all?

In essence I think this might be hard to maintain. Settings and tunings feel very unique to the databases and provide no abstraction. If some setting changes in behaviour we have no way to know or to debug.
A question comes to mind here: Should we really include the optimized versions at all? At least in the main branch. Maybe this is more a case for a branch that we allow to go stale?

How are the results and the data? Is there a clear relationship between settings and energy visible? Do T1 optimizations have similar energy improvements accross DBs?

@ribalba

ribalba commented Jul 8, 2026

Copy link
Copy Markdown
Member Author

The idea with the tuning was more that we can have training data for the AI model.

@ribalba

ribalba commented Jul 16, 2026

Copy link
Copy Markdown
Member Author

@ArneTR we should call about this.

@ribalba

ribalba commented Jul 17, 2026

Copy link
Copy Markdown
Member Author

Superseded by a two-way split of this branch:

The two branches together are byte-identical to new-dbs-and-tpch, so nothing is lost. Closing this in favour of the split.

@ribalba ribalba closed this Jul 17, 2026
@ribalba
ribalba deleted the new-dbs-and-tpch branch July 17, 2026 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants