Skip to content

Commit 3dcd4ee

Browse files
ozgengreenbonebot
authored andcommitted
test: fix leaks in security intelligence tests
1 parent 6757fd9 commit 3dcd4ee

2 files changed

Lines changed: 7 additions & 0 deletions

File tree

security_intelligence/security_intelligence.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -982,6 +982,8 @@ security_intelligence_delete_managed_appliance (
982982
return SECURITY_INTELLIGENCE_RESP_ERR;
983983
}
984984

985+
gvm_http_response_free (response);
986+
985987
return SECURITY_INTELLIGENCE_RESP_OK;
986988
}
987989

security_intelligence/security_intelligence_tests.c

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1388,6 +1388,7 @@ Ensure (security_intelligence,
13881388
security_intelligence_managed_appliance_t appliance = make_appliance ();
13891389
security_intelligence_managed_appliance_t created =
13901390
security_intelligence_managed_appliance_new ();
1391+
security_intelligence_managed_appliance_t old_created = created;
13911392
created->appliance_id = g_strdup ("old");
13921393

13931394
GPtrArray *errs = NULL;
@@ -1403,6 +1404,7 @@ Ensure (security_intelligence,
14031404

14041405
g_ptr_array_free (errs, TRUE);
14051406
security_intelligence_managed_appliance_free (appliance);
1407+
security_intelligence_managed_appliance_free (old_created);
14061408
security_intelligence_connector_free (conn);
14071409
}
14081410

@@ -1428,6 +1430,7 @@ Ensure (security_intelligence,
14281430

14291431
g_ptr_array_free (errs, TRUE);
14301432
security_intelligence_managed_appliance_free (appliance);
1433+
security_intelligence_managed_appliance_free (created);
14311434
security_intelligence_connector_free (conn);
14321435
}
14331436

@@ -2315,6 +2318,7 @@ Ensure (security_intelligence, create_report_sets_created_to_null_on_entry)
23152318
security_intelligence_connector_t conn = make_conn ();
23162319
security_intelligence_managed_report_t created =
23172320
security_intelligence_managed_report_new ();
2321+
security_intelligence_managed_report_t old_created = created;
23182322
GPtrArray *errs = NULL;
23192323

23202324
created->ref_id = g_strdup ("old-value");
@@ -2325,6 +2329,7 @@ Ensure (security_intelligence, create_report_sets_created_to_null_on_entry)
23252329
assert_that (created, is_null);
23262330

23272331
security_intelligence_connector_free (conn);
2332+
security_intelligence_managed_report_free (old_created);
23282333
}
23292334

23302335
Ensure (security_intelligence, create_report_fails_when_no_http_response)

0 commit comments

Comments
 (0)