Fix: Tune linking

qha · web-flow · commit 5c8ff4fab0f2 · 2025-06-26T08:39:49.000+02:00
Ensure all shared libraries are linked with other shared libraries declaring the symbols used.
diff --git a/boreas/CMakeLists.txt b/boreas/CMakeLists.txt
@@ -125,6 +125,7 @@ if(BUILD_SHARED)
       gvm_util_shared
       ${GLIB_LDFLAGS}
       ${LIBNET_LDFLAGS}
+      ${PCAP_LDFLAGS}
       ${LINKER_HARDENING_FLAGS}
       ${CMAKE_THREAD_LIBS_INIT}
   )
diff --git a/gmp/CMakeLists.txt b/gmp/CMakeLists.txt
@@ -43,7 +43,7 @@ if(BUILD_SHARED)
 
   target_link_libraries(
     gvm_gmp_shared
-    LINK_PRIVATE ${GLIB_LDFLAGS} ${LINKER_HARDENING_FLAGS}
+    LINK_PRIVATE gvm_util_shared ${GLIB_LDFLAGS} ${LINKER_HARDENING_FLAGS}
   )
 endif(BUILD_SHARED)
 
diff --git a/openvasd/CMakeLists.txt b/openvasd/CMakeLists.txt
@@ -58,7 +58,12 @@ if(BUILD_SHARED)
 
   target_link_libraries(
     gvm_openvasd_shared
-    LINK_PRIVATE ${GLIB_LDFLAGS} ${CURL_LDFLAGS} ${LINKER_HARDENING_FLAGS}
+    LINK_PRIVATE
+      gvm_http_shared
+      gvm_util_shared
+      ${GLIB_LDFLAGS}
+      ${CURL_LDFLAGS}
+      ${LINKER_HARDENING_FLAGS}
   )
 endif(BUILD_SHARED)
 
diff --git a/osp/CMakeLists.txt b/osp/CMakeLists.txt
@@ -43,7 +43,7 @@ if(BUILD_SHARED)
 
   target_link_libraries(
     gvm_osp_shared
-    LINK_PRIVATE ${GLIB_LDFLAGS} ${LINKER_HARDENING_FLAGS}
+    LINK_PRIVATE gvm_util_shared ${GLIB_LDFLAGS} ${LINKER_HARDENING_FLAGS}
   )
 endif(BUILD_SHARED)
 

Original file line number	Diff line number	Diff line change
`@@ -43,7 +43,7 @@ if(BUILD_SHARED)`
`43`	`43`
`44`	`44`	`target_link_libraries(`
`45`	`45`	`gvm_gmp_shared`
`46`		`- LINK_PRIVATE ${GLIB_LDFLAGS} ${LINKER_HARDENING_FLAGS}`
	`46`	`+ LINK_PRIVATE gvm_util_shared ${GLIB_LDFLAGS} ${LINKER_HARDENING_FLAGS}`
`47`	`47`	`)`
`48`	`48`	`endif(BUILD_SHARED)`
`49`	`49`