Fix: add const to tmp in parse_port_of_addr

This is required because addr is const and addr is being assigned to tmp via
strrchr.

As a result parse_port_of_addr also needs to return a const, and the test vars
need to be const.

Author: mattmundell

util/kb.c

@@ -246,10 +246,10 @@ redis_release_db (struct kb_redis *kbr)
   return rc;
 }
 
-static inline char *
+static inline const char *
 parse_port_of_addr (const char *addr, int tcp_indicator_len)
 {
-  char *tmp;
+  const char *tmp;
   int is_ip_v6;
   tmp = strrchr (addr + tcp_indicator_len, ':');
   if (tmp == NULL)
@@ -268,7 +268,8 @@ connect_redis (const char *addr, int len)
   const int redis_default_port = 6379;
 
   int port, host_len;
-  char *tmp, *host;
+  const char *tmp;
+  char *host;
   redisContext *result;
   static int warn_flag = 0;
 

util/kb_tests.c

@@ -26,7 +26,7 @@ AfterEach (kb)
 
 Ensure (kb, parse_port_of_addr)
 {
-  char *addr, *port;
+  const char *addr, *port;
 
   addr = TCP "xxx:5";
   port = parse_port_of_addr (addr, strlen (TCP));
@@ -35,7 +35,7 @@ Ensure (kb, parse_port_of_addr)
 
 Ensure (kb, parse_port_of_addr_missing)
 {
-  char *addr, *port;
+  const char *addr, *port;
 
   addr = TCP "xxx";
   port = parse_port_of_addr (addr, strlen (TCP));
@@ -44,7 +44,7 @@ Ensure (kb, parse_port_of_addr_missing)
 
 Ensure (kb, parse_port_of_addr_v6)
 {
-  char *addr, *port;
+  const char *addr, *port;
 
   addr = TCP "[2001:db8::1]:8080";
   port = parse_port_of_addr (addr, strlen (TCP));