Skip to content

Add/merge agent group crons#1071

Closed
ozgen wants to merge 3 commits into
mainfrom
add/merge-agent-group-crons
Closed

Add/merge agent group crons#1071
ozgen wants to merge 3 commits into
mainfrom
add/merge-agent-group-crons

Conversation

@ozgen
Copy link
Copy Markdown
Member

@ozgen ozgen commented May 18, 2026

What

  • Add support for merging scheduler cron values during agent config updates.
  • Remove the previous group cron from the agent cron list.
  • Add the new cron value from the update config.
  • Keep existing agent-specific cron values.
  • Allow duplicate cron values if they are provided.
  • Add unit tests for the new merge behavior.

Why

  • Agent groups can define a group-level cron.
  • Agents can still have their own cron values.
  • Duplicate handling should stay consistent with the provided cron list instead of silently filtering values.

References

GEA-1791

Checklist

  • Tests

ozgen added 2 commits May 18, 2026 11:41
 Add support for removing a previous scheduler cron time while merging new
 cron entries into the existing agent configuration. This allows group-level
 cron changes to be propagated without replacing agent-specific cron entries.
@ozgen ozgen requested review from a team as code owners May 18, 2026 09:47
@greenbonebot greenbonebot enabled auto-merge (rebase) May 18, 2026 09:47
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 18, 2026

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Snapshot Warnings

⚠️: No snapshots were found for the head SHA d8bcc59.
Ensure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice.

Scanned Files

None

…ller_agent_config_t and rename cron_time to prev_cron_time
@ozgen ozgen force-pushed the add/merge-agent-group-crons branch from 390cde9 to d8bcc59 Compare May 18, 2026 14:47
@ozgen ozgen closed this May 19, 2026
auto-merge was automatically disabled May 19, 2026 07:42

Pull request was closed

@ozgen ozgen deleted the add/merge-agent-group-crons branch May 19, 2026 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant