fixed test coverage

Author: robindittmar

gvm/protocols/gmp/requests/next/_credential_stores.py

@@ -35,7 +35,7 @@ def get_credential_stores(
         cmd = XmlCommand("get_credential_stores")
         cmd.add_filter(filter_string, filter_id)
 
-        if details:
+        if details is not None:
             cmd.set_attribute("details", to_bool(details))
 
         if credential_store_id:

gvm/protocols/gmp/requests/next/_credentials.py

@@ -5,7 +5,7 @@
 from typing import Optional, Union
 
 from gvm._enum import Enum
-from gvm.errors import RequiredArgument
+from gvm.errors import InvalidArgument, RequiredArgument
 from gvm.protocols.core import Request
 from gvm.utils import to_bool
 from gvm.xml import XmlCommand
@@ -103,33 +103,39 @@ def create_credential_store_credential(
             cmd.add_element("allow_insecure", to_bool(allow_insecure))
 
         if (
-            credential_type == CredentialStoreCredentialType.CLIENT_CERTIFICATE
-            or credential_type == CredentialStoreCredentialType.SNMP
-            or credential_type
-            == CredentialStoreCredentialType.USERNAME_PASSWORD
-            or credential_type == CredentialStoreCredentialType.USERNAME_SSH_KEY
-            or credential_type
-            == CredentialStoreCredentialType.SMIME_CERTIFICATE
-            or credential_type
-            == CredentialStoreCredentialType.PGP_ENCRYPTION_KEY
-            or credential_type == CredentialStoreCredentialType.PASSWORD_ONLY
+            credential_type != CredentialStoreCredentialType.CLIENT_CERTIFICATE
+            and credential_type != CredentialStoreCredentialType.SNMP
+            and credential_type
+            != CredentialStoreCredentialType.USERNAME_PASSWORD
+            and credential_type
+            != CredentialStoreCredentialType.USERNAME_SSH_KEY
+            and credential_type
+            != CredentialStoreCredentialType.SMIME_CERTIFICATE
+            and credential_type
+            != CredentialStoreCredentialType.PGP_ENCRYPTION_KEY
+            and credential_type != CredentialStoreCredentialType.PASSWORD_ONLY
         ):
-            if not vault_id:
-                raise RequiredArgument(
-                    function=cls.create_credential.__name__,
-                    argument="vault_id",
-                )
-            if not host_identifier:
-                raise RequiredArgument(
-                    function=cls.create_credential.__name__,
-                    argument="host_identifier",
-                )
+            raise InvalidArgument(
+                function=cls.create_credential.__name__,
+                argument="credential_type",
+            )
+
+        if not vault_id:
+            raise RequiredArgument(
+                function=cls.create_credential.__name__,
+                argument="vault_id",
+            )
+        if not host_identifier:
+            raise RequiredArgument(
+                function=cls.create_credential.__name__,
+                argument="host_identifier",
+            )
 
-            if credential_store_id:
-                cmd.add_element("credential_store_id", str(credential_store_id))
+        if credential_store_id:
+            cmd.add_element("credential_store_id", str(credential_store_id))
 
-            cmd.add_element("vault_id", vault_id)
-            cmd.add_element("host_identifier", host_identifier)
+        cmd.add_element("vault_id", vault_id)
+        cmd.add_element("host_identifier", host_identifier)
 
         return cmd
 

tests/protocols/gmpnext/entities/credential_stores/test_get_credential_stores.py

@@ -24,6 +24,19 @@ def test_get_credential_stores_with_filter_id(self):
             b'<get_credential_stores filt_id="f1"/>'
         )
 
+    def test_get_credential_stores_with_details(self):
+        self.gmp.get_credential_stores(details=True)
+
+        self.connection.send.has_been_called_with(
+            b'<get_credential_stores details="1"/>'
+        )
+
+        self.gmp.get_credential_stores(details=False)
+
+        self.connection.send.has_been_called_with(
+            b'<get_credential_stores details="0"/>'
+        )
+
     def test_get_credential_stores_with_id(self):
         self.gmp.get_credential_stores(credential_store_id="cs1")
 

tests/protocols/gmpnext/entities/credentials/test_modify_credential_store_credential.py

@@ -46,6 +46,27 @@ def test_modify_cs_credential_with_comment(self):
             b"</modify_credential>"
         )
 
+    def test_modify_cs_credential_with_allow_insecure(self):
+        self.gmp.modify_credential_store_credential(
+            credential_id="c1", allow_insecure=True
+        )
+
+        self.connection.send.has_been_called_with(
+            b'<modify_credential credential_id="c1">'
+            b"<allow_insecure>1</allow_insecure>"
+            b"</modify_credential>"
+        )
+
+        self.gmp.modify_credential_store_credential(
+            credential_id="c1", allow_insecure=False
+        )
+
+        self.connection.send.has_been_called_with(
+            b'<modify_credential credential_id="c1">'
+            b"<allow_insecure>0</allow_insecure>"
+            b"</modify_credential>"
+        )
+
     def test_modify_cs_credential_with_credential_store_id(self):
         self.gmp.modify_credential_store_credential(
             credential_id="c1", credential_store_id="foo"