CMakeLists.txt: use external gtest, fallback to fetching the source#288
Merged
greg7mdp merged 1 commit intogreg7mdp:masterfrom Oct 15, 2025
Merged
CMakeLists.txt: use external gtest, fallback to fetching the source#288greg7mdp merged 1 commit intogreg7mdp:masterfrom
greg7mdp merged 1 commit intogreg7mdp:masterfrom
Conversation
12 tasks
greg7mdp
approved these changes
Oct 15, 2025
Owner
greg7mdp
left a comment
There was a problem hiding this comment.
Thanks for the fix @barracuda156
Owner
|
Hum, This fails to build on linux. I get build errors: Looks like |
Contributor
Author
|
@greg7mdp I cannot test on Linux, but maybe then add an explicit option instead? So that it can be turned off or on. What does CMakeCache file has in the build directory? It is supposed to set paths to libs and headers. |
Owner
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #287