Merged
Conversation
Eliminate performance overhead in constructing begin() iterators on empty hash tables.
Owner
|
Nice, thanks for the PR @Caulm ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Eliminate performance overhead in constructing
begin()iterators on empty hash tables.When iterating over an empty
phmap::flat_hash_map,begin()unnecessarily calledskip_empty_or_deleted()on the first bucket, causing measurable overhead.This fix aligns with the approach already taken in Abseil: if the map is empty, simply return
end(). See raw_hash_set.h#L2355Benchmark (traversing empty map, capacity 100M, seconds):
std::unordered_mapphmap::flat_hash_mapphmap::flat_hash_map