lsusb.py: fix parse_usb_ids#241
Merged
Merged
Conversation
gregkh
requested changes
Jan 24, 2026
Owner
gregkh
left a comment
gregkh
left a comment
There was a problem hiding this comment.
Need a full name, not an email alias, on a signed-off-by line please.
cmheia
force-pushed
the
usb.ids
branch
2 times, most recently
from
2349c29 to
764a382
Compare
The commit 10144ac broke the usb.ids parser by renaming 'id' to 'vid' instead of 'cid' - fix that. Signed-off-by: MingHao Chen <cmheia@gmail.com>
Contributor
Author
done. |
Owner
|
Closing as this would add a bug, not fix anything. |
Owner
|
Oops, no, this looks correct, sorry abou tthat.. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The commit 10144ac broke the usb.ids parser by renaming 'id' to 'vid' instead of 'cid' - fix that.