Improve tests.

Author: gregschmit

test/app/controllers/api/test/find_by_controller.rb

@@ -0,0 +1,7 @@
+class Api::Test::FindByController < Api::TestController
+  self.model = User
+  self.fields = %w[id login age balance]
+  self.find_by_fields = %w[login]
+  self.filter_recordset_before_find = false
+  self.excluded_actions = [:create, :update, :destroy, :update_all, :destroy_all]
+end

test/config/routes.rb

@@ -57,6 +57,7 @@
       rest_resources :no_rescue_unknown_format
       rest_resources :read_only
       rest_resources :users_with_hidden
+      rest_resources :find_by
       rest_resources :users_with_sub_fields
 
       rest_route :network

test/config/simplecov_setup.rb

@@ -27,6 +27,9 @@
   add_filter "docs/"
   add_filter "test/"
 
+  # Filter out deprecated mixins.
+  add_filter "lib/rest_framework/mixins/"
+
   # Setup formatter for submission to `coveralls.io` if configured, otherwise use an HTML formatter.
   if IS_COVERALLS
     require "simplecov-lcov"

test/test/controllers/api/test/find_by_controller_test.rb

@@ -0,0 +1,17 @@
+require "test_helper"
+
+class Api::Test::FindByControllerTest < ActionController::TestCase
+  # Test showing a record by find_by (non-primary-key) field.
+  # Covers controller.rb lines 799-803, 812, 819.
+  def test_show_by_login
+    user = User.create!(login: "find_by_test_user", state: "default", status: "")
+    get(:show, as: :json, params: { id: user.login, find_by: "login" })
+    assert_response(:success)
+    assert_equal(user.login, @response.parsed_body["login"])
+  end
+
+  def test_show_by_login_not_found
+    get(:show, as: :json, params: { id: "nonexistent_login", find_by: "login" })
+    assert_response(404)
+  end
+end

test/test/controllers/api/test/users_controller_test.rb

@@ -0,0 +1,31 @@
+require "test_helper"
+
+class Api::Test::UsersControllerTest < ActionController::TestCase
+  # Test bulk update with a nonexistent record ID.
+  # Covers controller/bulk.rb lines 190, 196-197.
+  def test_bulk_update_missing_record
+    user = User.create!(login: "bulk_update_test", state: "default", status: "")
+    fake_id = User.maximum(:id) + 9999
+
+    patch(
+      :update_all,
+      as: :json,
+      params: { _json: [ { id: user.id, login: "updated" }, { id: fake_id, login: "ghost" } ] },
+    )
+    assert_response(400)
+    assert_match(/not found/, @response.parsed_body["message"])
+  end
+
+  # Test bulk destroy with a nonexistent record ID (transactional mode).
+  # Covers controller/bulk.rb lines 252-254.
+  def test_bulk_destroy_missing_record
+    user = User.create!(login: "bulk_destroy_test", state: "default", status: "")
+    fake_id = User.maximum(:id) + 9999
+
+    delete(:destroy_all, as: :json, params: { _json: [ user.id, fake_id ] })
+    assert_response(400)
+    assert_match(/Missing/, @response.parsed_body["message"])
+    # Transactional: user should still exist since destroy rolled back.
+    assert(User.find_by(id: user.id))
+  end
+end