Skip to content

Add seconds to timestamp#452

Open
graial wants to merge 2 commits into
greiman:masterfrom
graial:add-seconds-to-timestamp
Open

Add seconds to timestamp#452
graial wants to merge 2 commits into
greiman:masterfrom
graial:add-seconds-to-timestamp

Conversation

@graial
Copy link
Copy Markdown

@graial graial commented Nov 13, 2023

Needed seconds on my timestamps so added a set of functions.

The tz in src/ExFatLib/ExFatFilePrint.cpp is a magic number and I wasnt sure how you'd want to handle it within the library.

Not sure if you'd want to incorporate this or not. It's my first time attempting a pull request.

Cheers

@greiman
Copy link
Copy Markdown
Owner

greiman commented Nov 13, 2023

When I developed exFAT I started developing more data/time/time-zone functions. I finally decided to only provide the simple ones that were in FAT16/FAT32. These are also in FsFat. So for now I won't use this pull.

For future reference, I only add bug fixes to the release version of SdFat. New features go in SdFat-beta. I only update SdFat once or twice a year to avoid forcing users to install new versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants