Add missing update_trian! method for MultiField#112
Merged
JordiManyer merged 7 commits intogridap:masterfrom Jul 10, 2025
Merged
Add missing update_trian! method for MultiField#112JordiManyer merged 7 commits intogridap:masterfrom
JordiManyer merged 7 commits intogridap:masterfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #112 +/- ##
==========================================
+ Coverage 73.99% 77.04% +3.04%
==========================================
Files 18 31 +13
Lines 2546 3603 +1057
==========================================
+ Hits 1884 2776 +892
- Misses 662 827 +165 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
@zjwegert Looks good. Update NEWS and I'll merge. |
Contributor
Author
|
@JordiManyer FYI, I've also fixed precompilation in this PR. Waiting on tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Handle MultiFieldFEFunction inputs for shape differentiation through differentiable triangulations. E.g., for the case
φuh ∈ V_φu = MultiFieldFESpace([V_φ,U]),the existing
update_trian!implementation would do nothing becauseV_φu !== V_φ. The added method for multifield spaces checks each space to see if any are the space related to theDifferentiableTriangulation.