From 1f741ff75e316fd98d0679f88c71c4c5bef80465 Mon Sep 17 00:00:00 2001 From: Shreyas Date: Tue, 31 Mar 2026 13:53:00 +0200 Subject: [PATCH 1/7] bug fix in richardsonlinearsolver --- src/LinearSolvers/RichardsonLinearSolvers.jl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/LinearSolvers/RichardsonLinearSolvers.jl b/src/LinearSolvers/RichardsonLinearSolvers.jl index b5270d50..80817280 100644 --- a/src/LinearSolvers/RichardsonLinearSolvers.jl +++ b/src/LinearSolvers/RichardsonLinearSolvers.jl @@ -11,7 +11,7 @@ The relaxation parameter (ω) can either be of type Float64 or Vector{Float64}. This gives flexiblity in relaxation. """ struct RichardsonLinearSolver<:Gridap.Algebra.LinearSolver - ω::Union{Vector{Float64},Float64} + ω::Union{AbstractArray{Float64},Float64} Pl::Union{Gridap.Algebra.LinearSolver,Nothing} log::ConvergenceLog{Float64} end From 3f167f71fcaf9739c3d81fe10c5b77069eab163f Mon Sep 17 00:00:00 2001 From: Shreyas Date: Tue, 31 Mar 2026 14:04:11 +0200 Subject: [PATCH 2/7] update news.md --- NEWS.md | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/NEWS.md b/NEWS.md index 4405f7e5..29ebf218 100644 --- a/NEWS.md +++ b/NEWS.md @@ -5,6 +5,12 @@ All notable changes to this project will be documented in this file. The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html). +## Unreleased + +### Fixed + +- Updated RichardsonLinearSolver to generalize the relaxation parameter input as an abstract array. Since PR[#106](https://github.com/gridap/GridapSolvers.jl/pull/106/files). + ## [0.7.0] - 2026-03-10 ### Breaking From bd143e00f35497d9f3eda91fab2aed1dae8b4b7e Mon Sep 17 00:00:00 2001 From: Shreyas Date: Tue, 31 Mar 2026 14:08:38 +0200 Subject: [PATCH 3/7] update fix in richardsonlinearsolver --- src/LinearSolvers/RichardsonLinearSolvers.jl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/LinearSolvers/RichardsonLinearSolvers.jl b/src/LinearSolvers/RichardsonLinearSolvers.jl index 80817280..14877d8d 100644 --- a/src/LinearSolvers/RichardsonLinearSolvers.jl +++ b/src/LinearSolvers/RichardsonLinearSolvers.jl @@ -11,7 +11,7 @@ The relaxation parameter (ω) can either be of type Float64 or Vector{Float64}. This gives flexiblity in relaxation. """ struct RichardsonLinearSolver<:Gridap.Algebra.LinearSolver - ω::Union{AbstractArray{Float64},Float64} + ω::Union{AbstractVector{Float64},Float64} Pl::Union{Gridap.Algebra.LinearSolver,Nothing} log::ConvergenceLog{Float64} end From 949529806bc36e703ce1950659ee7a6dfe403f97 Mon Sep 17 00:00:00 2001 From: Shreyas Date: Tue, 31 Mar 2026 14:09:43 +0200 Subject: [PATCH 4/7] update news.md --- NEWS.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/NEWS.md b/NEWS.md index 29ebf218..2b075eca 100644 --- a/NEWS.md +++ b/NEWS.md @@ -9,7 +9,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ### Fixed -- Updated RichardsonLinearSolver to generalize the relaxation parameter input as an abstract array. Since PR[#106](https://github.com/gridap/GridapSolvers.jl/pull/106/files). +- Updated RichardsonLinearSolver to generalize the relaxation parameter input as an abstract vector. Since PR[#106](https://github.com/gridap/GridapSolvers.jl/pull/106/files). ## [0.7.0] - 2026-03-10 From f785f4a2ecfec3f361bdea528d5b570c13b0f528 Mon Sep 17 00:00:00 2001 From: Shreyas Date: Tue, 31 Mar 2026 14:11:00 +0200 Subject: [PATCH 5/7] update news.md --- NEWS.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/NEWS.md b/NEWS.md index 2b075eca..2eb10011 100644 --- a/NEWS.md +++ b/NEWS.md @@ -9,7 +9,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ### Fixed -- Updated RichardsonLinearSolver to generalize the relaxation parameter input as an abstract vector. Since PR[#106](https://github.com/gridap/GridapSolvers.jl/pull/106/files). +- Updated RichardsonLinearSolver to generalize the relaxation parameter input as an `AbstractVector`. Since PR[#106](https://github.com/gridap/GridapSolvers.jl/pull/106/files). ## [0.7.0] - 2026-03-10 From 99ac81e5ab2307a5aeba64f082f79f0195bbe46f Mon Sep 17 00:00:00 2001 From: Shreyas Prashanth Date: Tue, 31 Mar 2026 14:30:52 +0200 Subject: [PATCH 6/7] Update src/LinearSolvers/RichardsonLinearSolvers.jl Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --- src/LinearSolvers/RichardsonLinearSolvers.jl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/LinearSolvers/RichardsonLinearSolvers.jl b/src/LinearSolvers/RichardsonLinearSolvers.jl index 14877d8d..64c38362 100644 --- a/src/LinearSolvers/RichardsonLinearSolvers.jl +++ b/src/LinearSolvers/RichardsonLinearSolvers.jl @@ -8,7 +8,7 @@ Richardson Iteration, with an optional left preconditioners `Pl`. The relaxation parameter (ω) can either be of type Float64 or Vector{Float64}. -This gives flexiblity in relaxation. +This gives flexibility in relaxation. """ struct RichardsonLinearSolver<:Gridap.Algebra.LinearSolver ω::Union{AbstractVector{Float64},Float64} From ee0d9fd23fbe329dba7976173ec45b26622a53dc Mon Sep 17 00:00:00 2001 From: Shreyas Prashanth Date: Tue, 31 Mar 2026 14:31:05 +0200 Subject: [PATCH 7/7] Update NEWS.md Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --- NEWS.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/NEWS.md b/NEWS.md index 2eb10011..7e00beec 100644 --- a/NEWS.md +++ b/NEWS.md @@ -9,7 +9,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ### Fixed -- Updated RichardsonLinearSolver to generalize the relaxation parameter input as an `AbstractVector`. Since PR[#106](https://github.com/gridap/GridapSolvers.jl/pull/106/files). +- Updated `RichardsonLinearSolver` to also accept the relaxation parameter as an `AbstractVector{Float64}` (in addition to a scalar `Float64`). Since PR[#106](https://github.com/gridap/GridapSolvers.jl/pull/106/files). ## [0.7.0] - 2026-03-10