Skip to content

Minor update to RichardsonLinearSolver #106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JordiManyer merged 7 commits into from
Apr 23, 2026
Merged

Minor update to RichardsonLinearSolver #106

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
1f741ff
bug fix in richardsonlinearsolver
shreyas02 Mar 31, 2026
3f167f7
update news.md
shreyas02 Mar 31, 2026
bd143e0
update fix in richardsonlinearsolver
shreyas02 Mar 31, 2026
9495298
update news.md
shreyas02 Mar 31, 2026
f785f4a
update news.md
shreyas02 Mar 31, 2026
99ac81e
Update src/LinearSolvers/RichardsonLinearSolvers.jl
shreyas02 Mar 31, 2026
ee0d9fd
Update NEWS.md
shreyas02 Mar 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions NEWS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,12 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## Unreleased

### Fixed

- Updated `RichardsonLinearSolver` to also accept the relaxation parameter as an `AbstractVector{Float64}` (in addition to a scalar `Float64`). Since PR[#106](https://github.com/gridap/GridapSolvers.jl/pull/106/files).

## [0.7.0] - 2026-03-10

### Breaking
Expand Down
4 changes: 2 additions & 2 deletions src/LinearSolvers/RichardsonLinearSolvers.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,10 @@
Richardson Iteration, with an optional left preconditioners `Pl`.

The relaxation parameter (ω) can either be of type Float64 or Vector{Float64}.
This gives flexiblity in relaxation.
This gives flexibility in relaxation.
"""
struct RichardsonLinearSolver<:Gridap.Algebra.LinearSolver
ω::Union{Vector{Float64},Float64}
ω::Union{AbstractVector{Float64},Float64}

Copilot AI Mar 31, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using an abstract type (AbstractVector{Float64}) as a struct field can introduce dynamic dispatch/type-instability when ω is accessed inside hot loops. Consider making RichardsonLinearSolver parametric over the relaxation type (e.g., RichardsonLinearSolver{W} with ω::W and a constructor that restricts W to Float64 or AbstractVector{Float64}) to keep instances concretely typed while still accepting any AbstractVector implementation.

Copilot uses AI. Check for mistakes.

Copilot AI Mar 31, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The docstring above this struct still says the relaxation parameter can be a Vector{Float64}; with this change it should be updated to reflect AbstractVector{Float64} (or whatever types are intended) so user-facing docs match the actual accepted types.

Copilot uses AI. Check for mistakes.
Pl::Union{Gridap.Algebra.LinearSolver,Nothing}
log::ConvergenceLog{Float64}
end
Expand Down
Loading