Open
Conversation
adumesny
reviewed
Mar 30, 2026
Member
adumesny
left a comment
There was a problem hiding this comment.
thank you for making the fixes! I have a few small tweaks
# Conflicts: # src/dd-draggable.ts # src/gridstack.ts
Author
I resolved those comments |
adumesny
reviewed
Apr 5, 2026
| } | ||
|
|
||
| } | ||
| /*! |
Member
There was a problem hiding this comment.
please revert your changes here as every line (white space) have changed otherwise. Yes I can ingore in preview but still git histoty will show you as last person changing every lines.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR completes the RTL behavior in such a way that:
rtlis set. The originalPositionstruct has not changed, it still has aleftproperty, which now means "horizontal start position". When in rtl, it will be the position from the right.rtlflag everywhere.This closes the issue #819.
Checklist
masteryarn test) - the same tests fail onmaster