Skip to content

implemented full rtl support#3250

Open
danielgindi wants to merge 3 commits intogridstack:masterfrom
danielgindi:feature/full_rtl
Open

implemented full rtl support#3250
danielgindi wants to merge 3 commits intogridstack:masterfrom
danielgindi:feature/full_rtl

Conversation

@danielgindi
Copy link
Copy Markdown

@danielgindi danielgindi commented Mar 30, 2026

Description

This PR completes the RTL behavior in such a way that:

  1. Elements flow from right to left when rtl is set. The original Position struct has not changed, it still has a left property, which now means "horizontal start position". When in rtl, it will be the position from the right.
  2. Dragging - works correctly in rtl mode. With minimal changes to the code.
  3. Resizing - the same. The resize event has new properties to make it more semantic without testing for the rtl flag everywhere.

This closes the issue #819.

Checklist

  • Created tests which fail without the change (if possible) - not possible, tests already fail on master
  • All tests passing (yarn test) - the same tests fail on master
  • Extended the README / documentation, if necessary - not necessary

@danielgindi danielgindi changed the title implemented full rtl support implemented full rtl support (Closes #819) Mar 30, 2026
@danielgindi danielgindi changed the title implemented full rtl support (Closes #819) implemented full rtl support Mar 30, 2026
Copy link
Copy Markdown
Member

@adumesny adumesny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for making the fixes! I have a few small tweaks

# Conflicts:
#	src/dd-draggable.ts
#	src/gridstack.ts
@danielgindi
Copy link
Copy Markdown
Author

thank you for making the fixes! I have a few small tweaks

I resolved those comments

}

}
/*!
Copy link
Copy Markdown
Member

@adumesny adumesny Apr 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please revert your changes here as every line (white space) have changed otherwise. Yes I can ingore in preview but still git histoty will show you as last person changing every lines.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants