[WIP] Support Regulatory Fusions#1176
Open
acoffman wants to merge 19 commits into
Open
Conversation
acoffman
added
the
new-feature
acoffman
force-pushed
the
regulatory-fusions
branch
from
9afcd43 to
6d8e19c
Compare
| end | ||
| end | ||
|
|
||
| def regulatory_status_set_correctly(record) |
Contributor
There was a problem hiding this comment.
I think we should also add validation somewhere in this validator that two partners can't both be multiple and/or unknown. This is kinda covered by at_least_one_gene_id in a roundabout way but not explicitly.
Contributor
There was a problem hiding this comment.
I wonder if we should consider switching the order of the 5' Partner and 3' Partner description items in case the 3' Partner is regulatory (to match the feature name). Same for the order of the coordinates.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This introduces schema support for regulatory fusions.
Still todo before this can be merged:
We aren't using it directly yet but many of the regulatory fusion terms are SOID terms, so this also adds that linkage in case we want to leverage it in the future.