add cosmors for reranking after geom opt#139
Open
lmseidler wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request improves the handling of COSMO-RS solvent models in geometry optimizations, ensuring that when
cosmorsorcosmors-fineis selected, geometry optimizations are performed withdcosmorsand a final reranking is done using the chosen COSMO-RS model. It also adds related configuration options, updates reranking logic, and expands test coverage for these behaviors.COSMO-RS solvent model handling:
OptimizationConfigto supportCOSMORSandCOSMORS_FINEas valid solvent models, added agsolv_includedoption, and implemented logic to warn users and setgsolv_includedtoFalsewhen these models are selected. Geometry optimizations will usedcosmors, with a final reranking using the selected COSMO-RS model. [1] [2]optimizationworkflow, whenCOSMORSorCOSMORS_FINEis chosen, geometry optimization is performed withdcosmors, and a final single-point calculation is run with the selected COSMO-RS model for reranking. [1] [2]Testing improvements:
gsolv_includedis set toFalseand the appropriate warning is issued for COSMO-RS models, and that no warning is issued fordcosmors. Also added a test for the default value ofgsolv_included. [1] [2]Documentation and minor improvements:
h1andh2for clarity. [1] [2]