Bug Fix: Fock Matrix Autograd Support in scp_mode="fock"#214
Draft
MauriceDHanisch wants to merge 2 commits into
Draft
Bug Fix: Fock Matrix Autograd Support in scp_mode="fock"#214MauriceDHanisch wants to merge 2 commits into
MauriceDHanisch wants to merge 2 commits into
Conversation
…scp_mode Signed-off-by: MauriceDHanisch <maurhanisch@gmail.com>
for more information, see https://pre-commit.ci
| from tad_mctc.autograd import dgradcheck | ||
|
|
||
| from dxtb import GFN1_XTB as par | ||
| from dxtb import Calculator, OutputHandler, labels |
Check notice
Code scanning / CodeQL
Unused import
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #214 +/- ##
==========================================
+ Coverage 85.78% 85.80% +0.01%
==========================================
Files 202 202
Lines 10160 10160
Branches 1150 1150
==========================================
+ Hits 8716 8718 +2
+ Misses 1106 1105 -1
+ Partials 338 337 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BUG: When using
scp_mode="fock"computing the derivative of the Fock matrix with respect to atomic positions failed. This was due to the Fock matrix being disconnected from the computational graph.FIX: The issue was resolved by triggering one additional SCF cycle, which reconnects the Fock matrix and the computational graph. Similar to #212.
TEST: A regression test was added using
torch.autograd.gradcheck, which verifies that the Fock matrix is differentiable with respect to atomic positions.