Skip to content

Better isolate new chroot from host /dev, /dev/pts, /run/udev #347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
zeha wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Better isolate new chroot from host /dev, /dev/pts, /run/udev #347

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
074a2c1
Better isolate new chroot from host /dev, /dev/pts, /run/udev
zeha Jun 25, 2025
f9eb514
debug
zeha Jun 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions chroot-script
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -783,6 +783,12 @@ grub_install() {
return 1
fi

echo 'XXXXXXXXXXXXX mount output follows'
mount
echo 'XXXXXXXXXXXXX grub.cfg follows'
cat /boot/grub/grub.cfg
echo 'XXXXXXXXXXXXX end'

if mountpoint -q /boot/efi ; then
umount /boot/efi
fi
Expand Down
13 changes: 5 additions & 8 deletions grml-debootstrap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1814,12 +1814,6 @@ iface ${interface} inet dhcp
bailout 1
fi
fi

if [ -d /run/udev ] ; then
einfo "Setting up bind-mount /run/udev"
mkdir -p "${MNTPOINT}"/run/udev
mount --bind /run/udev "${MNTPOINT}"/run/udev
fi
}
# }}}

Expand Down Expand Up @@ -1879,8 +1873,11 @@ chrootscript() {
eend 1
else
einfo "Executing chroot-script now"
mount -t devtmpfs udev "${MNTPOINT}"/dev
mount -t devpts devpts "${MNTPOINT}"/dev/pts
# Linux kernel only has a *single* instance of devtmpfs. Mounting it
# with -t devtmpfs will give the chroot the *same* instance as the host has.
# To avoid modifying the host /dev, we provide a read-only bind mount.
mount -o bind,ro /dev "${MNTPOINT}"/dev
mount -t devpts -o newinstance devpts "${MNTPOINT}"/dev/pts
if [ "$DEBUG" = "true" ] ; then
clean_chroot "$MNTPOINT" /bin/bash -x /bin/chroot-script
else
Expand Down
Loading