Skip to content

Commit 69f5599

Browse files
committed
fix error handling properly
1 parent 88c143d commit 69f5599

1 file changed

Lines changed: 13 additions & 9 deletions

File tree

grobid_client/grobid_client.py

Lines changed: 13 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -511,17 +511,18 @@ def process_pdf(
511511
start=-1,
512512
end=-1
513513
):
514+
pdf_handle = None
514515
try:
515-
with open(pdf_file, "rb") as fi:
516+
pdf_handle = open(pdf_file, "rb")
516517

517-
files = {
518-
"input": (
519-
pdf_file,
520-
fi,
521-
"application/pdf",
522-
{"Expires": "0"},
523-
)
524-
}
518+
files = {
519+
"input": (
520+
pdf_file,
521+
pdf_handle,
522+
"application/pdf",
523+
{"Expires": "0"},
524+
)
525+
}
525526

526527
the_url = self.get_server_url(service)
527528

@@ -583,6 +584,9 @@ def process_pdf(
583584
return self._handle_request_error(pdf_file, e)
584585
except Exception as e:
585586
return self._handle_unexpected_error(pdf_file, e)
587+
finally:
588+
if pdf_handle:
589+
pdf_handle.close()
586590

587591
def get_server_url(self, service):
588592
return self.config['grobid_server'] + "/api/" + service

0 commit comments

Comments
 (0)