Skip to content

Optimize Dockerfile metadata extraction in generate-stackbrew-library.sh #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
keeganwitt wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Optimize Dockerfile metadata extraction in generate-stackbrew-library.sh #122

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions generate-stackbrew-library.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,8 +93,12 @@ for dir in "${directories[@]}"; do
dockerfile="$(git show "$commit:$dir/Dockerfile")"

# extract "FROM" and "GROOVY_VERSION" from Dockerfile
from="$(awk <<<"$dockerfile" 'toupper($1) == "FROM" { print $2; exit }')"
version="$(awk <<<"$dockerfile" -F '[=[:space:]]+' 'toupper($1) == "ENV" && $2 == "GROOVY_VERSION" { print $3; exit }')"
read -r from version <<<"$(awk <<<"$dockerfile" -F '[=[:space:]]+' '
toupper($1) == "FROM" && !from { from = $2 }
toupper($1) == "ENV" && $2 == "GROOVY_VERSION" && !version { version = $3 }
from && version { exit }
END { print from, version }
')"
# add a patch version of 0 if missing
if [[ "$version" =~ ^[0-9]+\.[0-9]+$ ]]; then
version="${version}.0"
Expand Down
Loading