add os(Android) compiler conditions#1754
Closed
gr-markin wants to merge 1 commit into
Closed
Conversation
Owner
|
Hello @gr-markin. Some work on Linux was performed in #1825 by @thinkpractice. An excellent work actually because instead of "just make it compile", features that had been disabled by previous "just make it compile on Linux" contributions were restored. That level of care is well appreciated. This pull request is obsolete. For further work on Android, please check other and recent pull requests and contact the involved contributors. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the compiler conditions required to build the library on Android. While PR#1708 also includes compiler conditions along with other code changes, this PR contains only the minimal changes needed for Android, which will hopefully simplify its acceptance.
developmentbranch.make smokeTestterminal command runs without failure.