Skip to content

add os(Android) compiler conditions#1754

Closed
gr-markin wants to merge 1 commit into
groue:developmentfrom
scade-platform:android_support
Closed

add os(Android) compiler conditions#1754
gr-markin wants to merge 1 commit into
groue:developmentfrom
scade-platform:android_support

Conversation

@gr-markin
Copy link
Copy Markdown

@gr-markin gr-markin commented Apr 1, 2025

This PR adds the compiler conditions required to build the library on Android. While PR#1708 also includes compiler conditions along with other code changes, this PR contains only the minimal changes needed for Android, which will hopefully simplify its acceptance.

  • CONTRIBUTING: You have read https://github.com/groue/GRDB.swift/blob/master/CONTRIBUTING.md
  • BRANCH: This pull request is submitted against the development branch.
  • DOCUMENTATION: Inline documentation has been updated.
  • DOCUMENTATION: README.md or another dedicated guide has been updated.
  • TESTS: Changes are tested.
  • TESTS: The make smokeTest terminal command runs without failure.

@groue
Copy link
Copy Markdown
Owner

groue commented Feb 1, 2026

Hello @gr-markin.

Some work on Linux was performed in #1825 by @thinkpractice. An excellent work actually because instead of "just make it compile", features that had been disabled by previous "just make it compile on Linux" contributions were restored. That level of care is well appreciated.

This pull request is obsolete. For further work on Android, please check other and recent pull requests and contact the involved contributors.

Thank you!

@groue groue closed this Feb 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants