Skip to content

Add support for maxInboundMetadataSize client configuration#1064

Merged
ST-DDT merged 6 commits into
grpc-ecosystem:masterfrom
o-shevchenko:maxInboundMetadataSize
Mar 13, 2024
Merged

Add support for maxInboundMetadataSize client configuration#1064
ST-DDT merged 6 commits into
grpc-ecosystem:masterfrom
o-shevchenko:maxInboundMetadataSize

Conversation

@o-shevchenko

Copy link
Copy Markdown
Contributor

Add support for maxInboundMetadataSize client configuration.
If metadata (for example an exception message) exceeds the limit we may receive a client error:

io.grpc.StatusRuntimeException: INTERNAL: RST_STREAM closed stream. HTTP/2 error code: PROTOCOL_ERROR

See: https://grpc.github.io/grpc-java/javadoc/io/grpc/ManagedChannelBuilder.html#maxInboundMetadataSize(int)
See: https://github.com/LogNet/grpc-spring-boot-starter/blob/master/grpc-spring-boot-starter/src/main/java/org/lognet/springboot/grpc/autoconfigure/GRpcServerProperties.java#L128

ST-DDT
ST-DDT previously approved these changes Mar 6, 2024
@o-shevchenko

Copy link
Copy Markdown
Contributor Author

@ST-DDT Thanks for the review!
What is the process of merging this PR? When we should expect next release with these changes?
Thanks!

@ST-DDT

ST-DDT commented Mar 7, 2024

Copy link
Copy Markdown
Collaborator

What is the process of merging this PR?

I have some free time next week to look into that.

@o-shevchenko

o-shevchenko commented Mar 11, 2024

Copy link
Copy Markdown
Contributor Author

It will also be great to merge changes for retries config: #574.
The lack of available configs is really a blocker in using this lib

@ST-DDT ST-DDT merged commit d75fba5 into grpc-ecosystem:master Mar 13, 2024
@yidongnan yidongnan added this to the 3.1.0 milestone Apr 12, 2024
@o-shevchenko o-shevchenko deleted the maxInboundMetadataSize branch April 19, 2024 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants