Skip to content

compileOnly for grpc-inprocess/implementation for grpc-netty-shaded#1072

Open
panchenko wants to merge 2 commits into
grpc-ecosystem:masterfrom
panchenko:review-scope
Open

compileOnly for grpc-inprocess/implementation for grpc-netty-shaded#1072
panchenko wants to merge 2 commits into
grpc-ecosystem:masterfrom
panchenko:review-scope

Conversation

@panchenko
Copy link
Copy Markdown

  • The grpc-inprocess module exists mostly for testing purposes, we don't need it at runtime.
  • The classes inside grpc-netty-shaded are repackaged, users are not supposed to access those internal packages, so implementation is enough

@shalk
Copy link
Copy Markdown
Contributor

shalk commented Apr 25, 2024

@panchenko
Copy link
Copy Markdown
Author

@shalk Thanks for the feedback, I will check the client more and might be split the change into multiple PRs to simplify the discussion.
Actually my main interest is the server, it works with grpc-inprocess excluded via gradle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants