compileOnly for grpc-inprocess/implementation for grpc-netty-shaded#1072
Open
panchenko wants to merge 2 commits into
Open
compileOnly for grpc-inprocess/implementation for grpc-netty-shaded#1072panchenko wants to merge 2 commits into
panchenko wants to merge 2 commits into
Conversation
Contributor
|
thought this is right. But may be user have to always add grpc-inprocess in dependencies. Because GrpcClientAutoConfiguration have use |
Author
|
@shalk Thanks for the feedback, I will check the client more and might be split the change into multiple PRs to simplify the discussion. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
grpc-inprocessmodule exists mostly for testing purposes, we don't need it at runtime.grpc-netty-shadedare repackaged, users are not supposed to access those internal packages, so implementation is enough