|
| 1 | +/* |
| 2 | + * |
| 3 | + * Copyright 2026 gRPC authors. |
| 4 | + * |
| 5 | + * Licensed under the Apache License, Version 2.0 (the "License"); |
| 6 | + * you may not use this file except in compliance with the License. |
| 7 | + * You may obtain a copy of the License at |
| 8 | + * |
| 9 | + * http://www.apache.org/licenses/LICENSE-2.0 |
| 10 | + * |
| 11 | + * Unless required by applicable law or agreed to in writing, software |
| 12 | + * distributed under the License is distributed on an "AS IS" BASIS, |
| 13 | + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. |
| 14 | + * See the License for the specific language governing permissions and |
| 15 | + * limitations under the License. |
| 16 | + * |
| 17 | + */ |
| 18 | + |
| 19 | +package resolver_test |
| 20 | + |
| 21 | +import ( |
| 22 | + "strings" |
| 23 | + "testing" |
| 24 | + |
| 25 | + iresolver "google.golang.org/grpc/internal/resolver" |
| 26 | + _ "google.golang.org/grpc/internal/resolver/passthrough" // Register passthrough resolver. |
| 27 | + "google.golang.org/grpc/resolver" |
| 28 | + _ "google.golang.org/grpc/resolver/dns" // Register dns resolver. |
| 29 | +) |
| 30 | + |
| 31 | +func TestParseTarget(t *testing.T) { |
| 32 | + tests := []struct { |
| 33 | + name string |
| 34 | + target string |
| 35 | + defaultScheme string |
| 36 | + wantScheme string |
| 37 | + wantErr bool |
| 38 | + errContain string |
| 39 | + }{ |
| 40 | + { |
| 41 | + name: "valid dns scheme", |
| 42 | + target: "dns:///example.com:443", |
| 43 | + wantScheme: "dns", |
| 44 | + }, |
| 45 | + { |
| 46 | + name: "valid passthrough scheme", |
| 47 | + target: "passthrough:///localhost:8080", |
| 48 | + wantScheme: "passthrough", |
| 49 | + }, |
| 50 | + { |
| 51 | + name: "valid dns scheme with default", |
| 52 | + target: "dns:///example.com:443", |
| 53 | + defaultScheme: "dns", |
| 54 | + wantScheme: "dns", |
| 55 | + }, |
| 56 | + { |
| 57 | + name: "missing scheme falls back to default", |
| 58 | + target: "/path/to/socket", |
| 59 | + defaultScheme: "passthrough", |
| 60 | + wantScheme: "passthrough", |
| 61 | + }, |
| 62 | + { |
| 63 | + name: "missing scheme without default", |
| 64 | + target: "/path/to/socket", |
| 65 | + wantErr: true, |
| 66 | + errContain: "has no scheme", |
| 67 | + }, |
| 68 | + { |
| 69 | + name: "host:port retries with default scheme", |
| 70 | + target: "localhost:8080", |
| 71 | + defaultScheme: "passthrough", |
| 72 | + wantScheme: "passthrough", |
| 73 | + }, |
| 74 | + { |
| 75 | + name: "host:port without default", |
| 76 | + target: "localhost:8080", |
| 77 | + wantErr: true, |
| 78 | + errContain: "no resolver registered for scheme", |
| 79 | + }, |
| 80 | + { |
| 81 | + name: "unregistered scheme", |
| 82 | + target: "unknown:///example.com:443", |
| 83 | + wantErr: true, |
| 84 | + errContain: "no resolver registered for scheme", |
| 85 | + }, |
| 86 | + { |
| 87 | + // Explicit hierarchical URI with unknown scheme is rejected even when |
| 88 | + // a default is provided. Only opaque URIs (host:port) fall back. |
| 89 | + name: "unregistered explicit scheme is rejected", |
| 90 | + target: "unknown:///foo", |
| 91 | + defaultScheme: "passthrough", |
| 92 | + wantErr: true, |
| 93 | + errContain: "no resolver registered for scheme", |
| 94 | + }, |
| 95 | + { |
| 96 | + name: "invalid URI", |
| 97 | + target: "dns:///example\x00.com", |
| 98 | + wantErr: true, |
| 99 | + errContain: "invalid target URI", |
| 100 | + }, |
| 101 | + } |
| 102 | + |
| 103 | + for _, tt := range tests { |
| 104 | + t.Run(tt.name, func(t *testing.T) { |
| 105 | + got, err := iresolver.ParseTarget(tt.target, tt.defaultScheme, resolver.Get) |
| 106 | + if (err != nil) != tt.wantErr { |
| 107 | + t.Errorf("ParseTarget(%q, %q) error = %v, wantErr %v", tt.target, tt.defaultScheme, err, tt.wantErr) |
| 108 | + return |
| 109 | + } |
| 110 | + if tt.wantErr { |
| 111 | + if tt.errContain != "" && !strings.Contains(err.Error(), tt.errContain) { |
| 112 | + t.Errorf("ParseTarget(%q, %q) error = %q, want it to contain %q", tt.target, tt.defaultScheme, err, tt.errContain) |
| 113 | + } |
| 114 | + return |
| 115 | + } |
| 116 | + if got.URL.Scheme != tt.wantScheme { |
| 117 | + t.Errorf("ParseTarget(%q, %q).URL.Scheme = %q, want %q", tt.target, tt.defaultScheme, got.URL.Scheme, tt.wantScheme) |
| 118 | + } |
| 119 | + }) |
| 120 | + } |
| 121 | +} |
| 122 | + |
| 123 | +func TestParseTargetWithCustomBuilder(t *testing.T) { |
| 124 | + // A registry that only recognises "passthrough". This mirrors the |
| 125 | + // cc.getResolver pattern in ClientConn, which may include resolvers |
| 126 | + // registered via dial options that are invisible to resolver.Get. |
| 127 | + passthroughOnly := func(scheme string) resolver.Builder { |
| 128 | + if scheme == "passthrough" { |
| 129 | + return resolver.Get("passthrough") |
| 130 | + } |
| 131 | + return nil |
| 132 | + } |
| 133 | + |
| 134 | + tests := []struct { |
| 135 | + name string |
| 136 | + target string |
| 137 | + defaultScheme string |
| 138 | + wantScheme string |
| 139 | + wantErr bool |
| 140 | + errContain string |
| 141 | + }{ |
| 142 | + { |
| 143 | + name: "known scheme resolves", |
| 144 | + target: "passthrough:///service:8080", |
| 145 | + wantScheme: "passthrough", |
| 146 | + }, |
| 147 | + { |
| 148 | + name: "dns not in custom registry", |
| 149 | + target: "dns:///example.com:443", |
| 150 | + wantErr: true, |
| 151 | + errContain: "no resolver registered for scheme", |
| 152 | + }, |
| 153 | + { |
| 154 | + // Explicit hierarchical URI: dns is not in the custom registry, and |
| 155 | + // unlike an opaque "host:port" URI, explicit schemes are not retried. |
| 156 | + name: "unregistered explicit scheme rejected even with default", |
| 157 | + target: "dns:///example.com:443", |
| 158 | + defaultScheme: "passthrough", |
| 159 | + wantErr: true, |
| 160 | + errContain: "no resolver registered for scheme", |
| 161 | + }, |
| 162 | + { |
| 163 | + // Opaque URI (host:port form) falls back to the default scheme. |
| 164 | + name: "host:port falls back to custom default", |
| 165 | + target: "service:8080", |
| 166 | + defaultScheme: "passthrough", |
| 167 | + wantScheme: "passthrough", |
| 168 | + }, |
| 169 | + { |
| 170 | + name: "missing scheme without default", |
| 171 | + target: "/path", |
| 172 | + wantErr: true, |
| 173 | + errContain: "has no scheme", |
| 174 | + }, |
| 175 | + { |
| 176 | + name: "missing scheme uses default", |
| 177 | + target: "/path", |
| 178 | + defaultScheme: "passthrough", |
| 179 | + wantScheme: "passthrough", |
| 180 | + }, |
| 181 | + } |
| 182 | + |
| 183 | + for _, tt := range tests { |
| 184 | + t.Run(tt.name, func(t *testing.T) { |
| 185 | + got, err := iresolver.ParseTarget(tt.target, tt.defaultScheme, passthroughOnly) |
| 186 | + if (err != nil) != tt.wantErr { |
| 187 | + t.Errorf("ParseTarget(%q, %q) error = %v, wantErr %v", tt.target, tt.defaultScheme, err, tt.wantErr) |
| 188 | + return |
| 189 | + } |
| 190 | + if tt.wantErr { |
| 191 | + if tt.errContain != "" && !strings.Contains(err.Error(), tt.errContain) { |
| 192 | + t.Errorf("ParseTarget(%q, %q) error = %q, want it to contain %q", tt.target, tt.defaultScheme, err, tt.errContain) |
| 193 | + } |
| 194 | + return |
| 195 | + } |
| 196 | + if got.URL.Scheme != tt.wantScheme { |
| 197 | + t.Errorf("ParseTarget(%q, %q).URL.Scheme = %q, want %q", tt.target, tt.defaultScheme, got.URL.Scheme, tt.wantScheme) |
| 198 | + } |
| 199 | + }) |
| 200 | + } |
| 201 | +} |
0 commit comments