Add interopt test using xDS client for a random_subsetting_experiment#9018
Add interopt test using xDS client for a random_subsetting_experiment#9018marek-szews wants to merge 2 commits into
Conversation
|
@marek-szews : please merge changes from the master branch into this PR branch. Thanks. |
arjan-bal
left a comment
There was a problem hiding this comment.
Please add the following test cases to validate xDS integration:
- Configuration parsing test here
- A test that configures random subsetting using xDS and verifies that the balancer is built and RPCs succeed. You can look at the following test that configures pickfirst:
grpc-go/internal/xds/balancer/clustermanager/e2e_test/clustermanager_test.go
Lines 198 to 222 in 2de5b1c
There was a problem hiding this comment.
The github.com/envoyproxy/go-control-plane/envoy dependency is already updated on the master branch. Can you please merge the master branch to remove this diff?
| // "The configuration for the Random Subsetting LB policy is the | ||
| // least_request_lb_config field. The field is optional; if not present, | ||
| // defaults will be assumed for all of its values." - A48 |
There was a problem hiding this comment.
"least_request_lb_config" - this seems like a copy/paste error. Can you please fix the comment?
| // "The configuration for the Random Subsetting LB policy is the | ||
| // least_request_lb_config field. The field is optional; if not present, | ||
| // defaults will be assumed for all of its values." - A48 | ||
| subsetSize := uint32(defaultRandomSubsetSize) |
There was a problem hiding this comment.
I quickly glanced through A68 and didn't find any mention of a defaultRandomSubsetSize. Is this behavior documented? If not, we should probably fail parsing if the subset size is less than 1.
There was a problem hiding this comment.
This doesn't appear to be an xDS or an interop test. It is a simple unit test that directly configures the LB policy through a static service config, instead of using xDS. Please remove this. Let's keep this PR focused on integrating the random subsetting policy with xDS and have the interop changes in separate PRs.
|
@marek-szews |
|
This PR is labeled as requiring an update from the reporter, and no update has been received after 6 days. If no update is provided in the next 7 days, this issue will be automatically closed. |
Enable interop testing for random subsetting Load Balancing policy (experimantal) to validate correctness and integration with existing child policies.
RELEASE NOTES:
Add interop test for a random_subsetting_experimental LB policy.