address comments

Author: shivaspeaks

cronet/build.gradle

@@ -58,7 +58,7 @@ dependencies {
 
 task javadocs(type: Javadoc) {
     source = android.sourceSets.main.java.srcDirs
-    // classpath += files(android.getBootClasspath())
+    classpath += files(android.getBootClasspath())
     classpath += files({
         android.libraryVariants.collect { variant ->
             variant.javaCompileProvider.get().classpath

xds/src/main/java/io/grpc/xds/XdsServerWrapper.java

@@ -417,6 +417,7 @@ public void onResourceChanged(final StatusOr<LdsUpdate> update) {
       }
 
       if (!pendingRds.isEmpty()) {
+        // filter chain state has not yet been applied to filterChainSelectorManager and there
         releaseSuppliersInFlight();
         pendingRds.clear();
       }

xds/src/main/java/io/grpc/xds/client/XdsClient.java

@@ -161,13 +161,6 @@ public interface ResourceWatcher<T extends ResourceUpdate> {
     /**
      * Called to deliver a transient error that should not affect the watcher's use of any
      * previously received resource.
-     *
-     * <p>Note that we expect that the implementer to:
-     * - Comply with the guarantee to not generate certain statuses by the library:
-     *   https://grpc.github.io/grpc/core/md_doc_statuscodes.html. If the code needs to be
-     *   propagated to the channel, override it with {@link io.grpc.Status.Code#UNAVAILABLE}.
-     * - Keep {@link Status} description in one form or another, as it contains valuable debugging
-     *   information.
      *   */
     void onAmbientError(Status error);
   }

xds/src/main/java/io/grpc/xds/client/XdsClientImpl.java

@@ -841,11 +841,9 @@ void onData(ParsedResource<T> parsedResource, String version, long updateTime,
       }
       if (!Objects.equals(oldData, data)) {
         StatusOr<T> update = StatusOr.fromValue(data);
-        for (Map.Entry<ResourceWatcher<T>, Executor> entry : watchers.entrySet()) {
-          ResourceWatcher<T> watcher = entry.getKey();
-          Executor executor = entry.getValue();
+        for (ResourceWatcher<T> watcher : watchers.keySet()) {
           processingTracker.startTask();
-          executor.execute(() -> {
+          watchers.get(watcher).execute(() -> {
             try {
               watcher.onResourceChanged(update);
             } finally {