Skip to content

Commit 3ebac15

Browse files
committed
Remove unused AtomicInteger in AsyncServletOutputStreamWriterTest
Error Prone flags AtomicInteger when only used by a single thread. The onWritePossibleCount variable was not needed for the test's verification — writtenData.size() is sufficient to confirm writes completed. Addressed kannanjgithub's review comment on PR #12790
1 parent 55e6629 commit 3ebac15

1 file changed

Lines changed: 0 additions & 3 deletions

File tree

servlet/src/test/java/io/grpc/servlet/AsyncServletOutputStreamWriterTest.java

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@
2525
import java.util.ArrayList;
2626
import java.util.List;
2727
import java.util.concurrent.atomic.AtomicBoolean;
28-
import java.util.concurrent.atomic.AtomicInteger;
2928
import java.util.function.BiFunction;
3029
import java.util.function.BooleanSupplier;
3130
import org.junit.Test;
@@ -50,7 +49,6 @@ public class AsyncServletOutputStreamWriterTest {
5049
public void writeBytes_alwaysReady_doesNotStall() throws IOException {
5150
AtomicBoolean isReady = new AtomicBoolean(true);
5251
List<byte[]> writtenData = new ArrayList<>();
53-
AtomicInteger onWritePossibleCount = new AtomicInteger(0);
5452

5553
BiFunction<byte[], Integer, ActionItem> writeAction =
5654
(bytes, numBytes) -> () -> {
@@ -72,7 +70,6 @@ public void writeBytes_alwaysReady_doesNotStall() throws IOException {
7270
// Simulate the first onWritePossible call (container init)
7371
isReady.set(true);
7472
writer.onWritePossible();
75-
onWritePossibleCount.incrementAndGet();
7673

7774
// Write multiple times while isReady stays true
7875
// Before the fix, writes would stall because isReady returned true

0 commit comments

Comments
 (0)