Skip to content

Commit 45edfbb

Browse files
committed
Fixup 12724: FilterContext -> FilterConfigParseContext
1 parent f1ba1a7 commit 45edfbb

12 files changed

Lines changed: 26 additions & 25 deletions

xds/src/main/java/io/grpc/xds/FaultFilter.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -105,7 +105,7 @@ public FaultFilter newInstance(String name) {
105105

106106
@Override
107107
public ConfigOrError<FaultConfig> parseFilterConfig(
108-
Message rawProtoMessage, FilterContext context) {
108+
Message rawProtoMessage, FilterConfigParseContext context) {
109109
HTTPFault httpFaultProto;
110110
if (!(rawProtoMessage instanceof Any)) {
111111
return ConfigOrError.fromError("Invalid config type: " + rawProtoMessage.getClass());
@@ -121,7 +121,7 @@ public ConfigOrError<FaultConfig> parseFilterConfig(
121121

122122
@Override
123123
public ConfigOrError<FaultConfig> parseFilterConfigOverride(
124-
Message rawProtoMessage, FilterContext context) {
124+
Message rawProtoMessage, FilterConfigParseContext context) {
125125
return parseFilterConfig(rawProtoMessage, context);
126126
}
127127

xds/src/main/java/io/grpc/xds/Filter.java

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -98,14 +98,14 @@ default boolean isServerFilter() {
9898
* com.google.protobuf.Any} or a {@link com.google.protobuf.Struct}.
9999
*/
100100
ConfigOrError<? extends FilterConfig> parseFilterConfig(
101-
Message rawProtoMessage, FilterContext context);
101+
Message rawProtoMessage, FilterConfigParseContext context);
102102

103103
/**
104104
* Parses the per-filter override filter config from raw proto message. The message may be
105105
* either a {@link com.google.protobuf.Any} or a {@link com.google.protobuf.Struct}.
106106
*/
107107
ConfigOrError<? extends FilterConfig> parseFilterConfigOverride(
108-
Message rawProtoMessage, FilterContext context);
108+
Message rawProtoMessage, FilterConfigParseContext context);
109109
}
110110

111111
/** Uses the FilterConfigs produced above to produce an HTTP filter interceptor for clients. */
@@ -133,13 +133,13 @@ default void close() {}
133133

134134
/** Context carrying dynamic metadata for a filter. */
135135
@AutoValue
136-
abstract static class FilterContext {
136+
abstract static class FilterConfigParseContext {
137137
abstract BootstrapInfo bootstrapInfo();
138138

139139
abstract ServerInfo serverInfo();
140140

141141
static Builder builder() {
142-
return new AutoValue_Filter_FilterContext.Builder();
142+
return new AutoValue_Filter_FilterConfigParseContext.Builder();
143143
}
144144

145145
@AutoValue.Builder
@@ -148,7 +148,7 @@ abstract static class Builder {
148148

149149
abstract Builder serverInfo(ServerInfo info);
150150

151-
abstract FilterContext build();
151+
abstract FilterConfigParseContext build();
152152
}
153153
}
154154

xds/src/main/java/io/grpc/xds/GcpAuthenticationFilter.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@ public GcpAuthenticationFilter newInstance(String name) {
8787

8888
@Override
8989
public ConfigOrError<GcpAuthenticationConfig> parseFilterConfig(
90-
Message rawProtoMessage, FilterContext context) {
90+
Message rawProtoMessage, FilterConfigParseContext context) {
9191
GcpAuthnFilterConfig gcpAuthnProto;
9292
if (!(rawProtoMessage instanceof Any)) {
9393
return ConfigOrError.fromError("Invalid config type: " + rawProtoMessage.getClass());
@@ -122,7 +122,7 @@ public ConfigOrError<GcpAuthenticationConfig> parseFilterConfig(
122122

123123
@Override
124124
public ConfigOrError<GcpAuthenticationConfig> parseFilterConfigOverride(
125-
Message rawProtoMessage, FilterContext context) {
125+
Message rawProtoMessage, FilterConfigParseContext context) {
126126
return parseFilterConfig(rawProtoMessage, context);
127127
}
128128
}

xds/src/main/java/io/grpc/xds/RbacFilter.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,7 @@ public RbacFilter newInstance(String name) {
9595

9696
@Override
9797
public ConfigOrError<RbacConfig> parseFilterConfig(
98-
Message rawProtoMessage, FilterContext context) {
98+
Message rawProtoMessage, FilterConfigParseContext context) {
9999
RBAC rbacProto;
100100
if (!(rawProtoMessage instanceof Any)) {
101101
return ConfigOrError.fromError("Invalid config type: " + rawProtoMessage.getClass());
@@ -111,7 +111,7 @@ public ConfigOrError<RbacConfig> parseFilterConfig(
111111

112112
@Override
113113
public ConfigOrError<RbacConfig> parseFilterConfigOverride(
114-
Message rawProtoMessage, FilterContext context) {
114+
Message rawProtoMessage, FilterConfigParseContext context) {
115115
RBACPerRoute rbacPerRoute;
116116
if (!(rawProtoMessage instanceof Any)) {
117117
return ConfigOrError.fromError("Invalid config type: " + rawProtoMessage.getClass());

xds/src/main/java/io/grpc/xds/RouterFilter.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -62,13 +62,13 @@ public RouterFilter newInstance(String name) {
6262

6363
@Override
6464
public ConfigOrError<? extends FilterConfig> parseFilterConfig(
65-
Message rawProtoMessage, FilterContext context) {
65+
Message rawProtoMessage, FilterConfigParseContext context) {
6666
return ConfigOrError.fromConfig(ROUTER_CONFIG);
6767
}
6868

6969
@Override
7070
public ConfigOrError<? extends FilterConfig> parseFilterConfigOverride(
71-
Message rawProtoMessage, FilterContext context) {
71+
Message rawProtoMessage, FilterConfigParseContext context) {
7272
return ConfigOrError.fromError("Router Filter should not have override config");
7373
}
7474
}

xds/src/main/java/io/grpc/xds/XdsListenerResource.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -618,7 +618,7 @@ static StructOrError<Filter.FilterConfig> parseHttpFilter(
618618
isForClient ? "client" : "server"));
619619
}
620620

621-
Filter.FilterContext filterContext = Filter.FilterContext.builder()
621+
Filter.FilterConfigParseContext filterContext = Filter.FilterConfigParseContext.builder()
622622
.bootstrapInfo(args.getBootstrapInfo())
623623
.serverInfo(args.getServerInfo())
624624
.build();

xds/src/main/java/io/grpc/xds/XdsRouteConfigureResource.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -211,7 +211,7 @@ private static StructOrError<VirtualHost> parseVirtualHost(
211211
static StructOrError<Map<String, FilterConfig>> parseOverrideFilterConfigs(
212212
Map<String, Any> rawFilterConfigMap, FilterRegistry filterRegistry,
213213
XdsResourceType.Args args) {
214-
Filter.FilterContext context = Filter.FilterContext.builder()
214+
Filter.FilterConfigParseContext context = Filter.FilterConfigParseContext.builder()
215215
.bootstrapInfo(args.getBootstrapInfo())
216216
.serverInfo(args.getServerInfo())
217217
.build();

xds/src/test/java/io/grpc/xds/FaultFilterTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -105,8 +105,8 @@ public void parseFaultAbort_withGrpcStatus() {
105105
assertThat(faultAbort.status().getCode()).isEqualTo(Code.DEADLINE_EXCEEDED);
106106
}
107107

108-
private static Filter.FilterContext getFilterContext() {
109-
return Filter.FilterContext.builder()
108+
private static Filter.FilterConfigParseContext getFilterContext() {
109+
return Filter.FilterConfigParseContext.builder()
110110
.bootstrapInfo(BootstrapInfo.builder()
111111
.servers(Collections.singletonList(
112112
ServerInfo.create(

xds/src/test/java/io/grpc/xds/GcpAuthenticationFilterTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -526,8 +526,8 @@ private static CdsUpdate getCdsUpdateWithIncorrectAudienceWrapper() throws IOExc
526526
return cdsUpdate.parsedMetadata(parsedMetadata.build()).build();
527527
}
528528

529-
private static Filter.FilterContext getFilterContext() {
530-
return Filter.FilterContext.builder()
529+
private static Filter.FilterConfigParseContext getFilterContext() {
530+
return Filter.FilterConfigParseContext.builder()
531531
.bootstrapInfo(BootstrapInfo.builder()
532532
.servers(Collections.singletonList(
533533
ServerInfo.create(

xds/src/test/java/io/grpc/xds/GrpcXdsClientImplDataTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1297,13 +1297,13 @@ public TestFilter newInstance(String name) {
12971297

12981298
@Override
12991299
public ConfigOrError<SimpleFilterConfig> parseFilterConfig(Message rawProtoMessage,
1300-
FilterContext context) {
1300+
FilterConfigParseContext context) {
13011301
return ConfigOrError.fromConfig(new SimpleFilterConfig(rawProtoMessage));
13021302
}
13031303

13041304
@Override
13051305
public ConfigOrError<SimpleFilterConfig> parseFilterConfigOverride(Message rawProtoMessage,
1306-
FilterContext context) {
1306+
FilterConfigParseContext context) {
13071307
return ConfigOrError.fromConfig(new SimpleFilterConfig(rawProtoMessage));
13081308
}
13091309
}

0 commit comments

Comments
 (0)