1. fix: retain original logic in NettyClientHandler.ChannelFutureListener.operationComplete

AgraVator · AgraVator · commit 5ce62670c645 · 2025-03-12T11:46:18.000+05:30
diff --git a/netty/src/main/java/io/grpc/netty/NettyClientHandler.java b/netty/src/main/java/io/grpc/netty/NettyClientHandler.java
@@ -857,9 +857,11 @@ public void operationComplete(ChannelFuture future) throws Exception {
         }
         Throwable cause = future.cause();
         Status status = lifecycleManager.getShutdownStatus();
-        if (cause instanceof ClosedChannelException && status == null) {
+        if (cause instanceof ClosedChannelException) {
+          if (status == null) {
             status = Status.UNKNOWN.withDescription("Ping failed but for unknown reason.")
-                .withCause(future.cause());
+                    .withCause(future.cause());
+          }
         } else {
           status = Utils.statusFromThrowable(cause);
         }

Original file line number	Diff line number	Diff line change
`@@ -857,9 +857,11 @@ public void operationComplete(ChannelFuture future) throws Exception {`
`857`	`857`	`}`
`858`	`858`	`Throwable cause = future.cause();`
`859`	`859`	`Status status = lifecycleManager.getShutdownStatus();`
`860`		`- if (cause instanceof ClosedChannelException && status == null) {`
	`860`	`+ if (cause instanceof ClosedChannelException) {`
	`861`	`+ if (status == null) {`
`861`	`862`	`status = Status.UNKNOWN.withDescription("Ping failed but for unknown reason.")`
`862`		`- .withCause(future.cause());`
	`863`	`+ .withCause(future.cause());`
	`864`	`+ }`
`863`	`865`	`} else {`
`864`	`866`	`status = Utils.statusFromThrowable(cause);`
`865`	`867`	`}`