Skip to content

Commit 696dd52

Browse files
committed
Revert "core: Fixed internal review points"
This reverts commit 67b2f3a.
1 parent 67b2f3a commit 696dd52

2 files changed

Lines changed: 2 additions & 3 deletions

File tree

core/src/main/java/io/grpc/internal/DelayedStream.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,6 @@ final Runnable setStream(ClientStream stream) {
129129
boolean cancelOldStream = false;
130130

131131
synchronized (this) {
132-
// If realStream != null, then either setStream() or cancel() has been called.
133132
if (realStream != null) {
134133
oldStream = realStream;
135134
cancelOldStream = listener != null;

core/src/test/java/io/grpc/internal/DelayedClientTransportTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -279,14 +279,14 @@ public void testNewStreamThenShutDownNow() {
279279
ClientStream stream = delayedTransport.newStream(
280280
method, new Metadata(), CallOptions.DEFAULT, tracers);
281281
stream.start(streamListener);
282-
assertEquals(1, delayedTransport.getPendingStreamsCount());
282+
assertEquals(1,delayedTransport.getPendingStreamsCount());
283283
delayedTransport.shutdownNow(Status.UNAVAILABLE);
284284
verify(transportListener).transportShutdown(any(Status.class));
285285
verify(transportListener).transportTerminated();
286286
verify(streamListener).closed(
287287
statusCaptor.capture(), any(RpcProgress.class), any(Metadata.class));
288288

289-
assertEquals(0, delayedTransport.getPendingStreamsCount());
289+
assertEquals(0,delayedTransport.getPendingStreamsCount());
290290
assertEquals(Status.Code.UNAVAILABLE, statusCaptor.getValue().getCode());
291291
}
292292

0 commit comments

Comments
 (0)