Skip to content

Commit 9f215ce

Browse files
committed
Remove usage of BACKEND_SERVICE_KEY from test
Tests shouldn't share constants with code-under-test unless it is the API contract.
1 parent 11ab7b5 commit 9f215ce

1 file changed

Lines changed: 3 additions & 3 deletions

File tree

opentelemetry/src/test/java/io/grpc/opentelemetry/OpenTelemetryMetricsModuleTest.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@
1717
package io.grpc.opentelemetry;
1818

1919
import static io.grpc.ClientStreamTracer.NAME_RESOLUTION_DELAYED;
20-
import static io.grpc.opentelemetry.internal.OpenTelemetryConstants.BACKEND_SERVICE_KEY;
2120
import static io.grpc.opentelemetry.internal.OpenTelemetryConstants.LOCALITY_KEY;
2221
import static io.grpc.opentelemetry.internal.OpenTelemetryConstants.METHOD_KEY;
2322
import static io.grpc.opentelemetry.internal.OpenTelemetryConstants.STATUS_KEY;
@@ -52,6 +51,7 @@
5251
import io.grpc.opentelemetry.OpenTelemetryMetricsModule.CallAttemptsTracerFactory;
5352
import io.grpc.opentelemetry.internal.OpenTelemetryConstants;
5453
import io.grpc.testing.GrpcServerRule;
54+
import io.opentelemetry.api.common.AttributeKey;
5555
import io.opentelemetry.api.metrics.Meter;
5656
import io.opentelemetry.sdk.common.InstrumentationScopeInfo;
5757
import io.opentelemetry.sdk.testing.junit4.OpenTelemetryRule;
@@ -1103,7 +1103,7 @@ public void clientBackendServiceMetrics_present() {
11031103

11041104
io.opentelemetry.api.common.Attributes clientAttributesWithBackendService
11051105
= clientAttributes.toBuilder()
1106-
.put(BACKEND_SERVICE_KEY, "the-moon")
1106+
.put(AttributeKey.stringKey("grpc.lb.backend_service"), "the-moon")
11071107
.build();
11081108

11091109
assertThat(openTelemetryTesting.getMetrics())
@@ -1168,7 +1168,7 @@ public void clientBackendServiceMetrics_missing() {
11681168

11691169
io.opentelemetry.api.common.Attributes clientAttributesWithBackendService
11701170
= clientAttributes.toBuilder()
1171-
.put(BACKEND_SERVICE_KEY, "")
1171+
.put(AttributeKey.stringKey("grpc.lb.backend_service"), "")
11721172
.build();
11731173

11741174
assertThat(openTelemetryTesting.getMetrics())

0 commit comments

Comments
 (0)