Skip to content

Commit b18ca55

Browse files
committed
update TODO
1 parent 600c22b commit b18ca55

1 file changed

Lines changed: 2 additions & 3 deletions

File tree

api/src/main/java/io/grpc/LoadBalancer.java

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -632,9 +632,8 @@ private PickResult(
632632
* stream is created at all in some cases.
633633
* @since 1.3.0
634634
*/
635-
// TODO(shivaspeaks): We need to deprecate old APIs and create new ones.
636-
// Ideally these static methods should start with "of.." instead of "with.."
637-
// to have consistency with other classes.
635+
// TODO(shivaspeaks): Need to deprecate old APIs and create new ones,
636+
// per https://github.com/grpc/grpc-java/issues/12662.
638637
public static PickResult withSubchannel(
639638
Subchannel subchannel, @Nullable ClientStreamTracer.Factory streamTracerFactory) {
640639
return new PickResult(

0 commit comments

Comments
 (0)