We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
1 parent 600c22b commit b18ca55Copy full SHA for b18ca55
1 file changed
api/src/main/java/io/grpc/LoadBalancer.java
@@ -632,9 +632,8 @@ private PickResult(
632
* stream is created at all in some cases.
633
* @since 1.3.0
634
*/
635
- // TODO(shivaspeaks): We need to deprecate old APIs and create new ones.
636
- // Ideally these static methods should start with "of.." instead of "with.."
637
- // to have consistency with other classes.
+ // TODO(shivaspeaks): Need to deprecate old APIs and create new ones,
+ // per https://github.com/grpc/grpc-java/issues/12662.
638
public static PickResult withSubchannel(
639
Subchannel subchannel, @Nullable ClientStreamTracer.Factory streamTracerFactory) {
640
return new PickResult(
0 commit comments