Skip to content

Commit bf8e597

Browse files
use GrpcCleanupRule to register new server in test
1 parent 56d96bd commit bf8e597

1 file changed

Lines changed: 9 additions & 6 deletions

File tree

xds/src/test/java/io/grpc/xds/GrpcXdsTransportFactoryTest.java

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -30,20 +30,24 @@
3030
import io.grpc.Server;
3131
import io.grpc.Status;
3232
import io.grpc.stub.StreamObserver;
33+
import io.grpc.testing.GrpcCleanupRule;
3334
import io.grpc.xds.client.Bootstrapper;
3435
import io.grpc.xds.client.XdsTransportFactory;
3536
import java.util.concurrent.BlockingQueue;
3637
import java.util.concurrent.LinkedBlockingQueue;
3738
import java.util.concurrent.TimeUnit;
3839
import org.junit.After;
3940
import org.junit.Before;
41+
import org.junit.Rule;
4042
import org.junit.Test;
4143
import org.junit.runner.RunWith;
4244
import org.junit.runners.JUnit4;
4345

4446
@RunWith(JUnit4.class)
4547
public class GrpcXdsTransportFactoryTest {
4648

49+
@Rule public final GrpcCleanupRule grpcCleanupRule = new GrpcCleanupRule();
50+
4751
private Server server;
4852

4953
@Before
@@ -144,10 +148,11 @@ public void refCountedXdsTransport_differentXdsServerAddress_returnsDifferentTra
144148
throws Exception {
145149
// Create and start a second xDS server on a different port.
146150
Server server2 =
147-
Grpc.newServerBuilderForPort(0, InsecureServerCredentials.create())
148-
.addService(echoAdsService())
149-
.build()
150-
.start();
151+
grpcCleanupRule.register(
152+
Grpc.newServerBuilderForPort(0, InsecureServerCredentials.create())
153+
.addService(echoAdsService())
154+
.build()
155+
.start());
151156
Bootstrapper.ServerInfo xdsServerInfo1 =
152157
Bootstrapper.ServerInfo.create(
153158
"localhost:" + server.getPort(), InsecureChannelCredentials.create());
@@ -168,8 +173,6 @@ public void refCountedXdsTransport_differentXdsServerAddress_returnsDifferentTra
168173
// Calling shutdown() shuts down the GrpcXdsTransport instance for the second xDS server.
169174
// The ref count was previously 1 and now is 0.
170175
transport2.shutdown();
171-
// Clean up the second xDS server.
172-
server2.shutdown();
173176
}
174177

175178
private static class FakeEventHandler implements

0 commit comments

Comments
 (0)