Skip to content

Commit c0b2b1d

Browse files
committed
upgrade cel
1 parent c5bf128 commit c0b2b1d

7 files changed

Lines changed: 10 additions & 16 deletions

File tree

MODULE.bazel

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -21,10 +21,8 @@ IO_GRPC_GRPC_JAVA_ARTIFACTS = [
2121
"com.google.re2j:re2j:1.8",
2222
"com.google.s2a.proto.v2:s2a-proto:0.1.3",
2323
"com.google.truth:truth:1.4.5",
24-
"dev.cel:runtime:0.11.1",
25-
"dev.cel:compiler:0.11.1",
26-
"dev.cel:protobuf:0.11.1",
27-
"org.antlr:antlr4-runtime:4.9.1",
24+
"dev.cel:runtime:0.12.0",
25+
"dev.cel:protobuf:0.12.0",
2826
"com.squareup.okhttp:okhttp:2.7.5",
2927
"com.squareup.okio:okio:2.10.0", # 3.0+ needs swapping to -jvm; need work to avoid flag-day
3028
"io.netty:netty-buffer:4.1.130.Final",

build.gradle

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,7 @@ subprojects {
4343
ignoreGradleMetadataRedirection()
4444
}
4545
}
46+
maven { url 'https://central.sonatype.com/repository/maven-snapshots/' }
4647
}
4748

4849
tasks.withType(JavaCompile).configureEach {

gradle/libs.versions.toml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -34,9 +34,9 @@ checkstyle = "com.puppycrawl.tools:checkstyle:10.26.1"
3434
# checkstyle 10.0+ requires Java 11+
3535
# See https://checkstyle.sourceforge.io/releasenotes_old_8-35_10-26.html#Release_10.0
3636
# checkForUpdates: checkstylejava8:9.+
37-
cel-runtime = "dev.cel:runtime:0.11.1"
38-
cel-protobuf = "dev.cel:protobuf:0.11.1"
39-
cel-compiler = "dev.cel:compiler:0.11.1"
37+
cel-runtime = "dev.cel:runtime:0.12.0"
38+
cel-protobuf = "dev.cel:protobuf:0.12.0"
39+
cel-compiler = "dev.cel:compiler:0.12.0"
4040
checkstylejava8 = "com.puppycrawl.tools:checkstyle:9.3"
4141
commons-math3 = "org.apache.commons:commons-math3:3.6.1"
4242
conscrypt = "org.conscrypt:conscrypt-openjdk-uber:2.5.2"

repositories.bzl

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -25,10 +25,8 @@ IO_GRPC_GRPC_JAVA_ARTIFACTS = [
2525
"com.google.re2j:re2j:1.8",
2626
"com.google.s2a.proto.v2:s2a-proto:0.1.3",
2727
"com.google.truth:truth:1.4.5",
28-
"dev.cel:runtime:0.11.1",
29-
"dev.cel:compiler:0.11.1",
30-
"dev.cel:protobuf:0.11.1",
31-
"org.antlr:antlr4-runtime:4.9.1",
28+
"dev.cel:runtime:0.12.0",
29+
"dev.cel:protobuf:0.12.0",
3230
"com.squareup.okhttp:okhttp:2.7.5",
3331
"com.squareup.okio:okio:2.10.0", # 3.0+ needs swapping to -jvm; need work to avoid flag-day
3432
"io.netty:netty-buffer:4.1.130.Final",

xds/BUILD.bazel

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,6 @@ java_library(
4343
artifact("com.google.re2j:re2j"),
4444
artifact("dev.cel:runtime"),
4545
artifact("dev.cel:protobuf"),
46-
artifact("org.antlr:antlr4-runtime"),
4746
artifact("io.netty:netty-buffer"),
4847
artifact("io.netty:netty-codec"),
4948
artifact("io.netty:netty-common"),

xds/build.gradle

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,6 @@ dependencies {
6262
implementation(libraries.cel.protobuf) {
6363
exclude group: 'com.google.protobuf', module: 'protobuf-java'
6464
}
65-
implementation "org.antlr:antlr4-runtime:4.9.1"
6665
def nettyDependency = implementation project(':grpc-netty')
6766

6867
testImplementation project(':grpc-api')

xds/src/main/java/io/grpc/xds/internal/matcher/CelCommon.java

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -43,9 +43,8 @@ final class CelCommon {
4343
return false;
4444
}
4545
if (func == StandardFunction.ADD) {
46-
// TODO: fix this, remove (object) casting when we upgrade to 0.12.0
47-
return !over.equals((Object) AddOverload.ADD_STRING)
48-
&& !over.equals((Object) AddOverload.ADD_LIST);
46+
return !over.equals(AddOverload.ADD_STRING)
47+
&& !over.equals(AddOverload.ADD_LIST);
4948
}
5049
return true;
5150
})

0 commit comments

Comments
 (0)