Commit fd971d1
authored
fix: configure Undertow test entity size (#12892)
fixes #12859
## Background
This PR updates the grpc-servlet Undertow tests to work with Undertow
`2.2.39.Final` and `2.3.21.Final`.
Those releases changed Undertow's default `MAX_ENTITY_SIZE` to 2 MiB,
which caused `UndertowInteropTest.veryLargeRequest()` to fail before the
request reached the gRPC servlet.
## Cause
`UndertowInteropTest.veryLargeRequest()` sends a 10 MiB unary request.
The test server already configured gRPC's `maxInboundMessageSize`, but
it did not configure Undertow's container-level entity size limit.
After the Undertow default changed, the container started rejecting the
request and the client saw `RST_STREAM ... CANCEL`.
## Changes
- Set `UndertowOptions.MAX_ENTITY_SIZE` explicitly in
`UndertowInteropTest`
- Set `UndertowOptions.MAX_ENTITY_SIZE` explicitly in
`UndertowTransportTest` to keep the transport test environment
effectively unbounded
- Upgrade Undertow test dependencies to `2.2.39.Final` and
`2.3.21.Final`
## Verification
- `./gradlew -PskipAndroid=true -PskipCodegen=true
:grpc-servlet:undertowTest --tests io.grpc.servlet.UndertowInteropTest`
- `./gradlew -PskipAndroid=true -PskipCodegen=true
:grpc-servlet:undertowTest --tests
io.grpc.servlet.UndertowTransportTest`1 parent c8079ee commit fd971d1
3 files changed
Lines changed: 8 additions & 9 deletions
File tree
- gradle
- servlet/src/undertowTest/java/io/grpc/servlet
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
146 | 146 | | |
147 | 147 | | |
148 | 148 | | |
149 | | - | |
150 | | - | |
151 | | - | |
152 | | - | |
153 | | - | |
154 | | - | |
155 | | - | |
156 | | - | |
157 | | - | |
| 149 | + | |
| 150 | + | |
| 151 | + | |
| 152 | + | |
Lines changed: 2 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
47 | 47 | | |
48 | 48 | | |
49 | 49 | | |
| 50 | + | |
50 | 51 | | |
51 | 52 | | |
52 | 53 | | |
| |||
101 | 102 | | |
102 | 103 | | |
103 | 104 | | |
| 105 | + | |
104 | 106 | | |
105 | 107 | | |
106 | 108 | | |
| |||
Lines changed: 2 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
63 | 63 | | |
64 | 64 | | |
65 | 65 | | |
| 66 | + | |
66 | 67 | | |
67 | 68 | | |
68 | 69 | | |
| |||
131 | 132 | | |
132 | 133 | | |
133 | 134 | | |
| 135 | + | |
134 | 136 | | |
135 | 137 | | |
136 | 138 | | |
| |||
0 commit comments