Stops exception allocation on channel shutdown#11955
Merged
Conversation
AgraVator
commented
Mar 11, 2025
ejona86
reviewed
Mar 11, 2025
ejona86
reviewed
Mar 11, 2025
Member
There was a problem hiding this comment.
This still hasn't been reverted.
Member
There was a problem hiding this comment.
This submodule shouldn't exist. It will be deleted when properly reverted.
2. deletes finalPing.failed(status); was called twice
…ener.operationComplete
Member
|
For the record, I had looked at this after you pushed your most recent commits, but I was still waiting for you to address all my comments. |
ejona86
reviewed
Mar 18, 2025
Member
ejona86
left a comment
ejona86
left a comment
There was a problem hiding this comment.
Just examples/grpc-java remains to be fixed
AgraVator
force-pushed
the
prevents-exception-allocation-on-channel-shutdown
branch
from
57c4ce8 to
5ce6267
Compare
ejona86
approved these changes
Mar 18, 2025
AgraVator
added a commit
to AgraVator/grpc-java
that referenced
this pull request
Dec 24, 2025
This fixes grpc#11955. Stops exception allocation and its propagation on channel shutdown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #10524