chore: Depend on xds module if under bzlmod#11980
Closed
honnix wants to merge 1 commit intogrpc:masterfrom
Closed
Conversation
Author
|
I understand this breaks dependency tree, so not meant to be taken in. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is no direct usage of
cel-specin grpc-java code base and it is only used bycom_github_cncf_xds. This has caused confusion like #11929. This PR usescom_github_cncf_xdsas a module if understand bzlmod, with fallback to plainhttp_archive.