Skip to content

prevents global stats config freeze in ConfiguratorRegistry.getConfigurators()#11991

Merged
AgraVator merged 2 commits intogrpc:masterfrom
AgraVator:prevents-global-stats-plugin-registry-freeze-from-get-configurators
Apr 4, 2025
Merged

prevents global stats config freeze in ConfiguratorRegistry.getConfigurators()#11991
AgraVator merged 2 commits intogrpc:masterfrom
AgraVator:prevents-global-stats-plugin-registry-freeze-from-get-configurators

Conversation

@AgraVator
Copy link
Copy Markdown
Contributor

No description provided.

@AgraVator AgraVator requested review from DNVindhya and ejona86 April 3, 2025 10:55
Comment thread core/src/test/java/io/grpc/internal/ServerImplBuilderTest.java
Comment thread api/src/main/java/io/grpc/ConfiguratorRegistry.java Outdated
Comment thread api/src/test/java/io/grpc/ConfiguratorRegistryTest.java
@AgraVator AgraVator requested a review from ejona86 April 3, 2025 14:39
Copy link
Copy Markdown
Member

@ejona86 ejona86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had originally considered setConfigurators() returning the count of calls before it was set. But we can consider/change that before we make this API public.

@AgraVator AgraVator merged commit d4c46a7 into grpc:master Apr 4, 2025
15 of 16 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants