Skip to content

core: Avoid Set.removeAll() when passing a possibly-large List #11994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kannanjgithub merged 1 commit into from
Apr 4, 2025
Merged

core: Avoid Set.removeAll() when passing a possibly-large List #11994

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion core/src/main/java/io/grpc/internal/DelayedClientTransport.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -325,7 +325,11 @@ final void reprocess(@Nullable SubchannelPicker picker) {
if (!hasPendingStreams()) {
return;
}
pendingStreams.removeAll(toRemove);
// Avoid pendingStreams.removeAll() as it can degrade to calling toRemove.contains() for each
// element in pendingStreams.
for (PendingStream stream : toRemove) {
pendingStreams.remove(stream);
}
// Because delayed transport is long-lived, we take this opportunity to down-size the
// hashmap.
if (pendingStreams.isEmpty()) {
Expand Down