Skip to content

Android: Clean up lint warnings and other warnings to get build success#12143

Merged
ejona86 merged 17 commits intogrpc:masterfrom
Sangamesh1997:Issue_fixed_12142
Aug 11, 2025
Merged

Android: Clean up lint warnings and other warnings to get build success#12143
ejona86 merged 17 commits intogrpc:masterfrom
Sangamesh1997:Issue_fixed_12142

Conversation

@Sangamesh1997
Copy link
Copy Markdown
Contributor

@Sangamesh1997 Sangamesh1997 commented Jun 10, 2025 •
edited
Loading

Fixes : #6868 #12142
Worked on clearing the lint warnings (OldTargetApi, ObsoleteSdkInt, InlinedApi, NewApi)

@Sangamesh1997
Copy link
Copy Markdown
Contributor Author

Sangamesh1997 commented Jun 19, 2025

@ejona86 @shivaspeaks Can you please review.

@kannanjgithub
Copy link
Copy Markdown
Contributor

kannanjgithub commented Jun 19, 2025

@Sangamesh1997 Can you provide the build error log that you are fixing with this PR? In the failing build.log of PR #12040 I don't see any errors about @TargetApi for example.

@shivaspeaks shivaspeaks added the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label Jun 19, 2025
@grpc-kokoro grpc-kokoro removed the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label Jun 19, 2025
@Sangamesh1997
Copy link
Copy Markdown
Contributor Author

Sangamesh1997 commented Jun 19, 2025

@kannanjgithub In the build log of PR #12040 , I observed that the only visible lint error was OldTargetApi. However, when I ran the lint check locally in (lint report.html), it also flagged other warnings like InlineApi, ObseleteSdkInt and NewApi, as mentioned by Eric earlier. So in this PR, I've fixed all these together to ensure build passes cleanly and is future-proof.

@kannanjgithub
Copy link
Copy Markdown
Contributor

kannanjgithub commented Jun 19, 2025

@Sangamesh1997 can you share that lint report.html?

@Sangamesh1997
Copy link
Copy Markdown
Contributor Author

Sangamesh1997 commented Jun 19, 2025 •
edited
Loading

@kannanjgithub lint report details.txt
lint

shivaspeaks
shivaspeaks reviewed Jun 19, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@shivaspeaks shivaspeaks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we working on silencing? I thought the discussion happened to upgrade and fix in the #12040 (comment)

@shivaspeaks shivaspeaks requested a review from ejona86 June 19, 2025 16:02
@Sangamesh1997
Copy link
Copy Markdown
Contributor Author

Sangamesh1997 commented Jun 20, 2025

Are we working on silencing? I thought the discussion happened to upgrade and fix in the #12040 (comment)

@shivaspeaks I have addressed and cleared all the lint warnings in #12143, which resolves the issue tracked in #6868.
Since the team is currently working on upgrading the Android Gradle Plugin (AGP) in #10152, the target SDK upgrade to 35/36 will be taken up after that is complete.
That’s why I focused on cleaning up the lint warnings first — to help unblock and resolve the 6868 issue as a separate step.

@Sangamesh1997 Sangamesh1997 mentioned this pull request Jun 26, 2025
Closed
@shivaspeaks shivaspeaks added the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label Jul 2, 2025
@grpc-kokoro grpc-kokoro removed the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label Jul 2, 2025
@shivaspeaks shivaspeaks self-requested a review July 8, 2025 08:32
@kannanjgithub
Copy link
Copy Markdown
Contributor

kannanjgithub commented Jul 10, 2025 •
edited
Loading

Since the team is currently working on upgrading the Android Gradle Plugin (AGP) in #10152, the target SDK upgrade to 35/36 will be taken up after that is complete.

Does it cause any problem if you set targetSdkVersion to the latest available even while the AGP is not upgraded yet? @Sangamesh1997

kannanjgithub
kannanjgithub reviewed Jul 10, 2025
View reviewed changes
Comment thread binder/src/main/java/io/grpc/binder/AndroidComponentAddress.java Outdated
kannanjgithub
kannanjgithub reviewed Jul 10, 2025
View reviewed changes
Comment thread binder/src/main/java/io/grpc/binder/internal/ServiceBinding.java
kannanjgithub
kannanjgithub reviewed Jul 10, 2025
View reviewed changes
Comment thread lint.xml
@Sangamesh1997
Merge remote-tracking branch 'origin/Issue_fixed_12142' into Issue_fi…
65fab31 
…xed_12142

# Conflicts:
#	binder/src/main/java/io/grpc/binder/internal/ServiceBinding.java
@Sangamesh1997 Sangamesh1997 reopened this Jul 11, 2025
@Sangamesh1997
Copy link
Copy Markdown
Contributor Author

Sangamesh1997 commented Jul 11, 2025

Since the team is currently working on upgrading the Android Gradle Plugin (AGP) in #10152, the target SDK upgrade to 35/36 will be taken up after that is complete.

Does it cause any problem if you set targetSdkVersion to the latest available even while the AGP is not upgraded yet? @Sangamesh1997

@kannanjgithub I tried and got a build failure with 'AAPT2 error: Android resourse linking failed'. SDK 35/36 introduced internal changes in resource formats. The current AGP versions cant handle these changes during resource linking. that's why I suspect that using compileSdk>34 is unsafe unless AGP is upgraded to 8.x.+.

ejona86
ejona86 reviewed Jul 28, 2025
View reviewed changes
Comment thread lint.xml
Comment thread binder/src/main/java/io/grpc/binder/internal/ServiceBinding.java
Comment thread binder/src/main/java/io/grpc/binder/AndroidComponentAddress.java Outdated
ejona86
ejona86 reviewed Aug 6, 2025
View reviewed changes
Comment thread binder/src/main/java/io/grpc/binder/AndroidComponentAddress.java
Comment thread binder/src/main/java/io/grpc/binder/internal/ServiceBinding.java Outdated
Comment thread binder/src/test/java/io/grpc/binder/internal/ServiceBindingTest.java Outdated
@ejona86 ejona86 added the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label Aug 6, 2025
@grpc-kokoro grpc-kokoro removed the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label Aug 6, 2025
jdcormie
jdcormie reviewed Aug 6, 2025
View reviewed changes
Comment thread binder/src/main/java/io/grpc/binder/internal/ServiceBinding.java Outdated
jdcormie
jdcormie reviewed Aug 6, 2025
View reviewed changes
Comment thread binder/src/test/java/io/grpc/binder/internal/ServiceBindingTest.java Outdated
@ejona86 ejona86 added the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label Aug 8, 2025
@grpc-kokoro grpc-kokoro removed the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label Aug 8, 2025
@ejona86 ejona86 merged commit f50726d into grpc:master Aug 11, 2025
20 of 21 checks passed
AgraVator pushed a commit to AgraVator/grpc-java that referenced this pull request Sep 26, 2025
@Sangamesh1997 @AgraVator
android: Clean up android lint and other warnings (grpc#12143)
67d42c4 
Worked on clearing the lint warnings (OldTargetApi, ObsoleteSdkInt,
InlinedApi, NewApi)

Fixes grpc#12142
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ejona86 ejona86 ejona86 approved these changes

@shivaspeaks shivaspeaks Awaiting requested review from shivaspeaks

@kannanjgithub kannanjgithub Awaiting requested review from kannanjgithub

@jdcormie jdcormie Awaiting requested review from jdcormie

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Teach Android build -PfailOnWarnings=true

6 participants

@Sangamesh1997 @kannanjgithub @ejona86 @jdcormie @shivaspeaks @grpc-kokoro