Upgrade errorprone annotations to 2.44.0#12520
Closed
marcindabrowski wants to merge 1 commit intogrpc:masterfrom
Closed
Upgrade errorprone annotations to 2.44.0#12520marcindabrowski wants to merge 1 commit intogrpc:masterfrom
marcindabrowski wants to merge 1 commit intogrpc:masterfrom
Conversation
In v2.37.0 the annotations that were previously in type_annotations artifact have been merged into annotations. Annotations added there: * com.google.errorprone.annotations.ImmutableTypeParameter, * com.google.errorprone.annotations.ThreadSafeTypeParameter. In next releases only Javadoc was changed. This update is enable updates of gson and guava libraries
ejona86
reviewed
Nov 19, 2025
Member
ejona86
left a comment
ejona86
left a comment
There was a problem hiding this comment.
gRPC wasn't using the type parameters, gRPC not having upgraded yet shouldn't impact anyone; everyone is free to upgrade error prone annotations themselves.
This change looks fine, although I'm upgrading all dependencies in #12522 as part of our post-release process, so we'll probably just favor that wider change instead of this one. There were the comments talking about how newer versions of error prone annotations caused trouble, but that seems to no longer be a problem, and so I've removed those comments/restrictions in my upgrade.
Contributor
Author
|
Great to see so many bumps. |
Member
|
We always bump Netty separately. It undergoes a lot more testing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In v2.37.0 the annotations that were previously in type_annotations artifact have been merged into annotations. Annotations added there:
In next releases only Javadoc was changed.
This update will enable updates of gson and guava libraries.