test: add another test case to confirm that issue 67 is fixed#12527
test: add another test case to confirm that issue 67 is fixed#12527James-4u wants to merge 1 commit intogrpc:masterfrom
Conversation
|
|
|
@ejona86 requesting your review |
|
Were the tests added in c28a7e3 insufficient? That issue should remain open until we flip GRPC_ENABLE_PER_RPC_AUTHORITY_CHECK to default to true. |
|
@ejona86 @kannanjgithub thanks for your reply. |
|
@SmartDever02 We do already have the unit tests that Eric mentioned in the above comment. Your PR creates a test that
|
This test verifies that hostname checking on :authority header works correctly
when multiple RPCs with different authority overrides are made on the same channel.
The test demonstrates:
I know #67 was fixed already, wanted to add a test case which ensures it's really solved and to close the issue as I thought it's not solved when I was looking at the repo issues.
Contribution by Gittensor, learn more at https://gittensor.io/