Skip to content

core: remove unused code from CompositeReadableBuffer#12531

Merged
ejona86 merged 1 commit intogrpc:masterfrom
panchenko:unused-code-CompositeReadableBuffer
Nov 26, 2025
Merged

core: remove unused code from CompositeReadableBuffer#12531
ejona86 merged 1 commit intogrpc:masterfrom
panchenko:unused-code-CompositeReadableBuffer

Conversation

@panchenko
Copy link
Copy Markdown
Contributor

I have looked into this class because it was mentioned in the stacktrace for the 2 recent reverts.

@panchenko panchenko marked this pull request as ready for review November 23, 2025 10:07
@ejona86 ejona86 self-requested a review November 25, 2025 05:23
Copy link
Copy Markdown
Member

@ejona86 ejona86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is reverting #3279 . Looks like it was a horribly busted merge. The original commit looked more useful 6034dd0

@ejona86 ejona86 added the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label Nov 25, 2025
@grpc-kokoro grpc-kokoro removed the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label Nov 25, 2025
@ejona86 ejona86 merged commit 6f3d3f6 into grpc:master Nov 26, 2025
16 of 17 checks passed
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Feb 25, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants