Skip to content

feat: support readBytes(ByteBuffer dest) for OkHttpReadableBuffer#12577

Closed
NguyenHoangSon96 wants to merge 1 commit intogrpc:masterfrom
NguyenHoangSon96:feat/okhttp-getBytes
Closed

feat: support readBytes(ByteBuffer dest) for OkHttpReadableBuffer#12577
NguyenHoangSon96 wants to merge 1 commit intogrpc:masterfrom
NguyenHoangSon96:feat/okhttp-getBytes

Conversation

@NguyenHoangSon96
Copy link
Copy Markdown

@NguyenHoangSon96 NguyenHoangSon96 commented Dec 22, 2025

Proposed Changes

  • Our project works with a library called arrow-java, and this library calls OkHttpReadableBuffer.readBytes(ByteBuffer dest) but this method was not implmented for grpc-okhttp so the calls failed. So I implemented this method so our project can work with arrow-java.
  • I have a talk with the team why this method is not implemented Here

Changes

  • Implement OkHttpReadableBuffer.readBytes(ByteBuffer dest).
  • Make readToByteBufferShouldSucceed test runs for OkHttpReadableBuffer.

Additional Information

  • Codecov complains about missing a test for throw new RuntimeException(e), I'm not sure if this line need to be tested.

@linux-foundation-easycla
Copy link
Copy Markdown

linux-foundation-easycla Bot commented Dec 22, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: NguyenHoangSon96 / name: sonnh (dbb5403)

@NguyenHoangSon96 NguyenHoangSon96 changed the title [EMPTY] trigger CI feat: support readBytes(ByteBuffer dest) for OkHttpReadableBuffer Dec 22, 2025
@NguyenHoangSon96 NguyenHoangSon96 marked this pull request as ready for review December 22, 2025 08:51
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Mar 23, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant