android-interop-testing: Remove usage of MultiDexApplication#12685
android-interop-testing: Remove usage of MultiDexApplication#12685ejona86 merged 3 commits intogrpc:masterfrom
Conversation
Since we're only supporting API levels 23+, all the supported Android versions handle multidex natively, and without any bugs to workaround. See also b/476359563
shivaspeaks
left a comment
shivaspeaks
left a comment
There was a problem hiding this comment.
We should also consider cleaning multiDexEnabled = true and the dependency implementation 'androidx.multidex:multidex:2.0.0' from android-interop-testing/build.gradle?
|
|
||
| <application | ||
| android:name="android.support.multidex.MultiDexApplication" > | ||
| <application> |
There was a problem hiding this comment.
We can delete this empty <application> </application> tags?
There was a problem hiding this comment.
It doesn't matter either way, and I'd rather it be identical to the internal CL (so that the internal one doesn't need modifying).
There was a problem hiding this comment.
Okay, I was concerned because this will not be caught in the follow-up cleanup and this remains empty tag lying there as a dead code forever.. but nevermind. I approved.
|
Yeah, I was thinking of removing those other things as well, but was mostly just externalizing the one change here. |
Also bump some minSdkVersion that didn't get updated in fa7b52b
|
I went ahead and removed the other references to multidex in the build.gradle files, since we do build-specific stuff in the internal CL as well. But I do realize there's still more cleanups available (e.g., gradle/libs.versions.toml now that minSdkVersion is bumped). That stuff will need to be follow-up. |
shivaspeaks
left a comment
shivaspeaks
left a comment
There was a problem hiding this comment.
But I do realize there's still more cleanups available (e.g., gradle/libs.versions.toml now that minSdkVersion is bumped). That stuff will need to be follow-up.
We should create a tracking issue for this then.
|
|
||
| <application | ||
| android:name="android.support.multidex.MultiDexApplication" > | ||
| <application> |
sure it is built before being used
```
Execution failed for task ':grpc-android-interop-testing:mergeExtDexDebug'.
> Could not resolve all files for configuration ':grpc-android-interop-testing:debugRuntimeClasspath'.
> Failed to transform opencensus-contrib-grpc-metrics-0.31.1.jar (io.opencensus:opencensus-contrib-grpc-metrics:0.31.1) to match attributes {artifactType=android-dex, asm-transformed-variant=NONE, dexing-enable-desugaring=true, dexing-enable-jacoco-instrumentation=false, dexing-is-debuggable=true, dexing-min-sdk=23, org.gradle.category=library, org.gradle.libraryelements=jar, org.gradle.status=release, org.gradle.usage=java-runtime}.
> Could not resolve all files for configuration ':grpc-android-interop-testing:debugRuntimeClasspath'.
> Failed to transform grpc-api-1.81.0-SNAPSHOT.jar (project :grpc-api) to match attributes {artifactType=android-classes-jar, org.gradle.category=library, org.gradle.dependency.bundling=external, org.gradle.jvm.version=8, org.gradle.libraryelements=jar, org.gradle.usage=java-runtime}.
> Execution failed for IdentityTransform: /grpc-java/api/build/libs/grpc-api-1.81.0-SNAPSHOT.jar.
> File/directory does not exist: /grpc-java/api/build/libs/grpc-api-1.81.0-SNAPSHOT.jar
```
3 participants
Since we're only supporting API levels 23+, all the supported Android versions handle multidex natively, and without any bugs to workaround.
See also b/476359563
cl/872773139. CC @kannanjgithub