Replace javax ThreadSafe annotation with errorprone ThreadSafe#12742
Replace javax ThreadSafe annotation with errorprone ThreadSafe#12742Kainsin wants to merge 1 commit intogrpc:masterfrom
Conversation
|
|
e9d7eda to
6c131f2
Compare
|
This is essentially the next step past #8687 . Still not totally off javax, but this should unblock projects that are affected by immutables/immutables#1529 👍 |
|
/gcbrun |
|
The usage of javax.annotation.concurrent.ThreadSafe in grpc-java creates a specific risk for downstream projects, particularly those using the Immutables library on Java 11+, due to the following reasons: 1. Dependency on JSR-305 2. High-Impact Subclassing
3. The "Immutables" Compilation Failure
...will suffer a full project compilation failure. The Immutables processor will see the ThreadSafe annotation on the gRPC superclass, find it missing from the classpath, and crash. 4. Modular Java (JPMS) Conflicts Summary of Problems
|
Replace the javax ThreadSafe annotation with the errorprone ThreadSafe annotation. This change should help Java 9+ projects that do not use the javax namespace.