examples: Clean up Health, and document need for grpc-services#12743
Merged
ejona86 merged 3 commits intogrpc:masterfrom Apr 10, 2026
Merged
examples: Clean up Health, and document need for grpc-services#12743ejona86 merged 3 commits intogrpc:masterfrom
ejona86 merged 3 commits intogrpc:masterfrom
Conversation
For something like this, putting all the config together in service config is what we would want to encourage. Remove unused/needless variables. Emphasize health checking more than round-robin. Add missing synchronization on server-side.
dfawley
approved these changes
Apr 1, 2026
examples/src/main/java/io/grpc/examples/healthservice/HealthServiceClient.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Doug Fawley <dfawley@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For something like this, putting all the config together in service config is what we would want to encourage. Remove unused/needless variables. Emphasize health checking more than round-robin. Add missing synchronization on server-side.
@dfawley was looking at the example and asking me about it. grpc-services is pretty important, and it wasn't mentioned at all.